Bugzilla – Attachment 162380 Details for
Bug 23781
Recalls notices and messaging preferences
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 23781: (QA follow-up) Implement phone notice in code
Bug-23781-QA-follow-up-Implement-phone-notice-in-c.patch (text/plain), 1.91 KB, created by
Kyle M Hall (khall)
on 2024-02-23 14:47:57 UTC
(
hide
)
Description:
Bug 23781: (QA follow-up) Implement phone notice in code
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2024-02-23 14:47:57 UTC
Size:
1.91 KB
patch
obsolete
>From 8f8b34ce27b7fba0b020799e479c75f953b3e9a8 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 23 Feb 2024 14:45:43 +0000 >Subject: [PATCH] Bug 23781: (QA follow-up) Implement phone notice in code > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > Koha/Recall.pm | 7 +------ > Koha/Recalls.pm | 7 +------ > 2 files changed, 2 insertions(+), 12 deletions(-) > >diff --git a/Koha/Recall.pm b/Koha/Recall.pm >index 334dda10024..f898f0335c6 100644 >--- a/Koha/Recall.pm >+++ b/Koha/Recall.pm >@@ -361,12 +361,7 @@ sub set_waiting { > my $messaging_preferences = C4::Members::Messaging::GetMessagingPreferences( > { borrowernumber => $self->patron_id, message_name => 'Recall_Waiting' } ); > while ( my ( $transport, $letter_code ) = each %{ $messaging_preferences->{transports} } ) { >- if ( $transport eq 'email' ) { >- C4::Message->enqueue( $letter, $self->patron, 'email' ); >- } >- if ( $transport eq 'sms' ) { >- C4::Message->enqueue( $letter, $self->patron, 'sms' ); >- } >+ C4::Message->enqueue( $letter, $self->patron, $transport ); > } > > return $self; >diff --git a/Koha/Recalls.pm b/Koha/Recalls.pm >index dbafc98f238..9f6d14e3640 100644 >--- a/Koha/Recalls.pm >+++ b/Koha/Recalls.pm >@@ -171,12 +171,7 @@ sub add_recall { > { borrowernumber => $checkout->borrowernumber, message_name => 'Recall_Requested' } ); > > while ( my ( $transport, $letter_code ) = each %{ $messaging_preferences->{transports} } ) { >- if ( $transport eq 'email' ) { >- C4::Message->enqueue( $letter, $checkout->patron, 'email' ); >- } >- if ( $transport eq 'sms' ) { >- C4::Message->enqueue( $letter, $checkout->patron, 'sms' ); >- } >+ C4::Message->enqueue( $letter, $checkout->patron, $transport ); > } > > $item = Koha::Items->find( $itemnumber ); >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 23781
:
93905
|
104984
|
131702
|
132044
|
140242
|
140244
|
147107
|
148248
|
148260
|
150430
|
150441
|
155346
|
158696
|
158697
|
158698
|
159013
|
159014
|
159015
|
162377
|
162378
|
162379
|
162380
|
165240
|
165241
|
165242
|
165593
|
165614
|
165615
|
165616
|
165617
|
169201
|
169202
|
169203
|
169204
|
169205