Bugzilla – Attachment 162403 Details for
Bug 35911
Archived suggestions show in patron's account
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35911: Make archived suggestions not show in patron's account
Bug-35911-Make-archived-suggestions-not-show-in-pa.patch (text/plain), 1.57 KB, created by
Shi Yao Wang
on 2024-02-23 20:07:48 UTC
(
hide
)
Description:
Bug 35911: Make archived suggestions not show in patron's account
Filename:
MIME Type:
Creator:
Shi Yao Wang
Created:
2024-02-23 20:07:48 UTC
Size:
1.57 KB
patch
obsolete
>From d5e47555cf3652c7c1858a778296de3e00e11102 Mon Sep 17 00:00:00 2001 >From: Shi Yao Wang <shi-yao.wang@inlibro.com> >Date: Fri, 23 Feb 2024 15:01:43 -0500 >Subject: [PATCH] Bug 35911: Make archived suggestions not show in patron's > account > >Remove archived suggestions in patron's account page > >Test plan: >1. Go to a patron's account in the staff interface >2. Go to the Suggestions tab >3. Click New purchase suggestion and create a suggestion >4. In another browser tab, go to Acquisitions > Suggestions >5. Click the small arrow next to the edit button to the right of the suggestion, and choose Archive (alternatively, check the suggestion's box and click Archive selected) > --> Suggestion disappears from the suggestions management page (OK) >6. Go back to the tab with the patron's account and refresh > --> Suggestion is still visible >7. Apply the patch >8. Redo step 6 and notice the suggestion is not visible anymore >9. Redo step 4 and 5 but this time, unarchiving the suggestion >10. Redo step 6 and notice the suggestion is back >--- > members/purchase-suggestions.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/members/purchase-suggestions.pl b/members/purchase-suggestions.pl >index 1739e841ae..0268582bef 100755 >--- a/members/purchase-suggestions.pl >+++ b/members/purchase-suggestions.pl >@@ -49,7 +49,7 @@ $template->param( > ); > > my $suggestions = [ >- Koha::Suggestions->search_limited( { suggestedby => $borrowernumber }, >+ Koha::Suggestions->search_limited( { suggestedby => $borrowernumber, archived => 0 }, > { prefetch => 'managedby' } )->as_list > ]; > >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35911
:
162403
|
162419
|
162583