Attachment 162415 Details for Bug 28869 – Bug 28869: (follow-up) Add html restriction for tinyint

[patch] Bug 28869: (follow-up) Add html restriction for tinyint

Bug-28869-follow-up-Add-html-restriction-for-tinyi.patch (text/plain), 2.02 KB, created by Victor Grousset/tuxayo on 2024-02-26 06:01:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2024-02-26 06:01:39 UTC

Size: 2.02 KB

patch

obsolete

>From 2fad9d8e85d2e79720e673e53c8fbf3e1e6d53aa Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 5 Feb 2024 09:34:49 +0000
>Subject: [PATCH] Bug 28869: (follow-up) Add html restriction for tinyint
>
>Several item fields are signed tinyints, connected to
>authorised value categories like NOT_LOAN etc. They only
>accept -128 up to 127.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> .../intranet-tmpl/prog/en/modules/admin/authorised_values.tt    | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>index aa9045241a..b55cc730f4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/authorised_values.tt
>@@ -171,7 +171,7 @@
>                                             <input type="hidden" id="id" name="id" value="[% av.id | html %]" />
>                                         [% END %]
>                                         [% IF ( av && av.is_integer_only ) || category.is_integer_only %]
>-                                            <input type="text" inputmode="numeric" pattern="[% num_pattern | $raw %]" id="authorised_value" name="authorised_value" value="[% av.authorised_value | html %]" class="focus" title="Should be numeric" required/>
>+                                            <input type="text" inputmode="numeric" pattern="[% num_pattern | $raw %]" min="-128" max="127" id="authorised_value" name="authorised_value" value="[% av.authorised_value | html %]" class="focus" title="Should be numeric (-128..127)" required/>
>                                         [% ELSE %]
>                                             <input type="text" id="authorised_value" name="authorised_value" value="[% av.authorised_value | html %]" maxlength="80" class="focus"/>
>                                         [% END %]
>-- 
>2.44.0

Actions: View | Diff | Splinter Review

Attachments on bug 28869: 161745 | 161746 | 161747 | 161748 | 161749 | 162412 | 162413 | 162414 | 162415 | 162416 | 163996 | 163997 | 163998 | 163999 | 164000 | 164001 | 166697 | 166698 | 166699 | 166700 | 166701 | 166702 | 166906