Bugzilla – Attachment 162482 Details for
Bug 35959
Inconsistent hierarchy during C3 merge of class 'Koha::AuthorisedValue' (and a few other modules)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35959: (follow-up) Do not push, but refill ISA
Bug-35959-follow-up-Do-not-push-but-refill-ISA.patch (text/plain), 2.66 KB, created by
Victor Grousset/tuxayo
on 2024-02-27 06:32:04 UTC
(
hide
)
Description:
Bug 35959: (follow-up) Do not push, but refill ISA
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2024-02-27 06:32:04 UTC
Size:
2.66 KB
patch
obsolete
>From 24579f29a7f54377e1b72f591d5340924f2588d8 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Wed, 31 Jan 2024 15:04:45 +0000 >Subject: [PATCH] Bug 35959: (follow-up) Do not push, but refill ISA > >Test plan: >- Run qa tools on patch set that touches one of the modules. >(I used bug 28869 touching AuthorisedValue.pm. it depends on this bug, >so just apply 28869 on main/master) > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > Koha/Account/DebitType.pm | 2 +- > Koha/AuthorisedValue.pm | 2 +- > Koha/Patron/Attribute/Type.pm | 2 +- > Koha/Patron/Category.pm | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/Koha/Account/DebitType.pm b/Koha/Account/DebitType.pm >index 8cc2645566..4f2f38ad70 100644 >--- a/Koha/Account/DebitType.pm >+++ b/Koha/Account/DebitType.pm >@@ -25,7 +25,7 @@ use Koha::Database; > use Koha::Exceptions; > > # Bug 35959 - Avoid Inconsistent hierarchy warn by replacing use base line >-push @Koha::Account::DebitType::ISA, qw(Koha::Object Koha::Object::Limit::Library); >+@Koha::Account::DebitType::ISA = qw(Koha::Object Koha::Object::Limit::Library); > > =head1 NAME > >diff --git a/Koha/AuthorisedValue.pm b/Koha/AuthorisedValue.pm >index e756b1abc1..407df68917 100644 >--- a/Koha/AuthorisedValue.pm >+++ b/Koha/AuthorisedValue.pm >@@ -25,7 +25,7 @@ use Koha::Object; > use Koha::Object::Limit::Library; > > # Bug 35959 - Avoid Inconsistent hierarchy warn by replacing use base line >-push @Koha::AuthorisedValue::ISA, qw(Koha::Object Koha::Object::Limit::Library); >+@Koha::AuthorisedValue::ISA = qw(Koha::Object Koha::Object::Limit::Library); > > my $cache = Koha::Caches->get_instance(); > >diff --git a/Koha/Patron/Attribute/Type.pm b/Koha/Patron/Attribute/Type.pm >index 88166d927a..12a9a9878f 100644 >--- a/Koha/Patron/Attribute/Type.pm >+++ b/Koha/Patron/Attribute/Type.pm >@@ -24,7 +24,7 @@ use Koha::Database; > use Koha::Exceptions::Patron::Attribute::Type; > > # Bug 35959 - Avoid Inconsistent hierarchy warn by replacing use base line >-push @Koha::Patron::Attribute::Type::ISA, qw(Koha::Object Koha::Object::Limit::Library); >+@Koha::Patron::Attribute::Type::ISA = qw(Koha::Object Koha::Object::Limit::Library); > > =head1 NAME > >diff --git a/Koha/Patron/Category.pm b/Koha/Patron/Category.pm >index edc86d1881..ffb52e0e09 100644 >--- a/Koha/Patron/Category.pm >+++ b/Koha/Patron/Category.pm >@@ -25,7 +25,7 @@ use Koha::Database; > use Koha::DateUtils qw( dt_from_string ); > > # Bug 35959 - Avoid Inconsistent hierarchy warn by replacing use base line >-push @Koha::Patron::Category::ISA, qw(Koha::Object Koha::Object::Limit::Library); >+@Koha::Patron::Category::ISA = qw(Koha::Object Koha::Object::Limit::Library); > > =head1 NAME > >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35959
:
161690
|
161692
|
161693
|
162410
|
162411
|
162481
|
162482
|
162483
|
164468
|
164469
|
164470
|
164471
|
166926
|
166927
|
166928
|
166929
|
168427
|
168441
|
168442
|
168443
|
168444
|
168445
|
168566