Attachment 162498 Details for Bug 35724 – Bug 35724: Sync database update and kohasctructure and set to int(11)

[patch] Bug 35724: Sync database update and kohasctructure and set to int(11)

Bug-35724-Sync-database-update-and-kohasctructure-.patch (text/plain), 2.99 KB, created by Martin Renvoize (ashimema) on 2024-02-27 11:13:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-02-27 11:13:19 UTC

Size: 2.99 KB

patch

obsolete

>From c5db1074f37c95544d5e3122ffbbc1ae947f10e7 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Tue, 27 Feb 2024 11:01:42 +0000
>Subject: [PATCH] Bug 35724: Sync database update and kohasctructure and set to
> int(11)
>
>We use int(11) in the smtp_servers table for port, so I think it makes
>sense to use the same here too.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> ...5724-add_upload_port_and_download_port_columns.pl | 12 ++++++------
> installer/data/mysql/kohastructure.sql               |  4 ++--
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_35724-add_upload_port_and_download_port_columns.pl b/installer/data/mysql/atomicupdate/bug_35724-add_upload_port_and_download_port_columns.pl
>index ac2855bdc39..c823a103f51 100755
>--- a/installer/data/mysql/atomicupdate/bug_35724-add_upload_port_and_download_port_columns.pl
>+++ b/installer/data/mysql/atomicupdate/bug_35724-add_upload_port_and_download_port_columns.pl
>@@ -7,24 +7,24 @@ return {
>         my ($args) = @_;
>         my ( $dbh, $out ) = @$args{qw(dbh out)};
> 
>-        if ( !column_exists( 'vendor_edi_accounts', 'upload_port' ) ) {
>+        if ( !column_exists( 'vendor_edi_accounts', 'download_port' ) ) {
>             $dbh->do(
>                 q{
>-              ALTER TABLE vendor_edi_accounts ADD COLUMN `upload_port` varchar(40) DEFAULT '22' AFTER `password`
>+              ALTER TABLE vendor_edi_accounts ADD COLUMN `download_port` int(11) DEFAULT NULL AFTER `password`
>           }
>             );
> 
>-            say $out "Added column 'vendor_edi_accounts.upload_port'";
>+            say $out "Added column 'vendor_edi_accounts.download_port'";
>         }
> 
>-        if ( !column_exists( 'vendor_edi_accounts', 'download_port' ) ) {
>+        if ( !column_exists( 'vendor_edi_accounts', 'upload_port' ) ) {
>             $dbh->do(
>                 q{
>-              ALTER TABLE vendor_edi_accounts ADD COLUMN `download_port` varchar(40) DEFAULT '22' AFTER `password`
>+              ALTER TABLE vendor_edi_accounts ADD COLUMN `upload_port` int(11) DEFAULT NULL AFTER `download_port`
>           }
>             );
> 
>-            say $out "Added column 'vendor_edi_accounts.download_port'";
>+            say $out "Added column 'vendor_edi_accounts.upload_port'";
>         }
>     },
> };
>diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql
>index 9b2f2d02fe3..cf19b0bf7f3 100644
>--- a/installer/data/mysql/kohastructure.sql
>+++ b/installer/data/mysql/kohastructure.sql
>@@ -6427,8 +6427,8 @@ CREATE TABLE `vendor_edi_accounts` (
>   `host` varchar(40) DEFAULT NULL,
>   `username` varchar(40) DEFAULT NULL,
>   `password` mediumtext DEFAULT NULL,
>-  `upload_port` varchar(40) DEFAULT NULL,
>-  `download_port` varchar(40) DEFAULT NULL,
>+  `upload_port` int(11) DEFAULT NULL,
>+  `download_port` int(11) DEFAULT NULL,
>   `last_activity` date DEFAULT NULL,
>   `vendor_id` int(11) DEFAULT NULL,
>   `download_directory` mediumtext DEFAULT NULL,
>-- 
>2.43.2

Actions: View | Diff | Splinter Review

Attachments on bug 35724: 160644 | 160645 | 160646 | 160717 | 160718 | 160719 | 160720 | 162494 | 162495 | 162496 | 162497 | 162498 | 162499