Attachment 162546 Details for Bug 36027 – Bug 36027 : Tidy the code

[patch] Bug 36027 : Tidy the code

Bug-36027--tidy-check-1.patch (text/plain), 1.81 KB, created by Phan Tung Bui on 2024-02-28 17:25:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Phan Tung Bui

Created: 2024-02-28 17:25:20 UTC

Size: 1.81 KB

patch

obsolete

>From f840bcba676f09ecc976b4f74d408c51c331bc2a Mon Sep 17 00:00:00 2001
>From: Phan Tung Bui <phan-tung.bui@inlibro.com>
>Date: Wed, 28 Feb 2024 12:22:20 -0500
>Subject: [PATCH] Bug 36027 : tidy check 1
>
>---
> misc/maintenance/search_for_data_inconsistencies.pl | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
>diff --git a/misc/maintenance/search_for_data_inconsistencies.pl b/misc/maintenance/search_for_data_inconsistencies.pl
>index 2f7b7a8a80..d7c9344ccf 100755
>--- a/misc/maintenance/search_for_data_inconsistencies.pl
>+++ b/misc/maintenance/search_for_data_inconsistencies.pl
>@@ -16,7 +16,6 @@
> # along with Koha; if not, see <http://www.gnu.org/licenses>.
> 
> use Modern::Perl;
>-
> use Koha::Script;
> use Koha::AuthorisedValues;
> use Koha::Authorities;
>@@ -62,7 +61,6 @@ CheckItemsFramework() if $options{'framework'};
> CheckItemsTitle()     if $options{'title'};
> CheckAgeForCategory() if $options{'age'};
> 
>-
> sub CheckItemsBranch {
>     my $items = Koha::Items->search({ -or => { homebranch => undef, holdingbranch => undef }});
>     if ( $items->count ) { new_section("Not defined items.homebranch and/or items.holdingbranch")}
>@@ -372,7 +370,6 @@ sub new_hint {
>     say "=> $name";
> }
> 
>-
> =head1 SYNOPSIS
> 
> search_for_data_inconsistencies.pl [options]
>@@ -385,7 +382,7 @@ Catch data inconsistencies in Koha database:
>     * Authorities with undefined authtypecodes/authority types
>     * Item types:
>         * if item types are defined at item level (item-level_itypes=specific item),
>-            then items.itype must be set else biblioitems.itemtype must be set
>+        then items.itype must be set else biblioitems.itemtype must be set
>         * Item types defined in items or biblioitems must be defined in the itemtypes table
>     * Bibliographic records without a title
>     * Invalid MARCXML in bibliographic records
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 36027: 161852 | 161953 | 161954 | 162162 | 162349 | 162351 | 162540 | 162546 | 163259 | 163956 | 166117 | 167766 | 167787 | 168953 | 168954 | 169228 | 169229 | 170847 | 170848 | 170849 | 173269 | 173270 | 173271 | 173556