Attachment 162645 Details for Bug 35469 – Bug 35469: Add 'manage_bookings' permission to biblios/checkouts

[patch] Bug 35469: Add 'manage_bookings' permission to biblios/checkouts

Bug-35469-Add-managebookings-permission-to-biblios.patch (text/plain), 3.60 KB, created by Marcel de Rooy on 2024-03-01 08:52:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-03-01 08:52:59 UTC

Size: 3.60 KB

patch

obsolete

>From 31b951ec276232a342bda11f02497e39a54a95b2 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Tue, 19 Dec 2023 13:30:14 +0000
>Subject: [PATCH] Bug 35469: Add 'manage_bookings' permission to
> biblios/checkouts
>Content-Type: text/plain; charset=utf-8
>
>This patch adds the manage_bookings subpermission check to the
>biblios/{biblio_id}/checkouts endpoint and updates the corresponding
>unit test too.
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> api/v1/swagger/paths/biblios.yaml |  3 ++-
> t/db_dependent/api/v1/biblios.t   | 42 +++++++++++++++++++++++++++----
> 2 files changed, 39 insertions(+), 6 deletions(-)
>
>diff --git a/api/v1/swagger/paths/biblios.yaml b/api/v1/swagger/paths/biblios.yaml
>index 17a5ffc11f..3070253557 100644
>--- a/api/v1/swagger/paths/biblios.yaml
>+++ b/api/v1/swagger/paths/biblios.yaml
>@@ -403,7 +403,8 @@
>           $ref: "../swagger.yaml#/definitions/error"
>     x-koha-authorization:
>       permissions:
>-        circulate: circulate_remaining_permissions
>+        - circulate: circulate_remaining_permissions
>+        - circulate: manage_bookings
> "/biblios/{biblio_id}/items":
>   get:
>     x-mojo-to: Biblios#get_items
>diff --git a/t/db_dependent/api/v1/biblios.t b/t/db_dependent/api/v1/biblios.t
>index 5bd719a9f3..cd08c57c23 100755
>--- a/t/db_dependent/api/v1/biblios.t
>+++ b/t/db_dependent/api/v1/biblios.t
>@@ -726,7 +726,7 @@ subtest 'get_bookings() tests' => sub {
> 
> subtest 'get_checkouts() tests' => sub {
> 
>-    plan tests => 14;
>+    plan tests => 17;
> 
>     $schema->storage->txn_begin;
> 
>@@ -745,11 +745,43 @@ subtest 'get_checkouts() tests' => sub {
>     $t->get_ok("//$userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/checkouts")
>       ->status_is(403);
> 
>-    $patron->flags(1)->store; # circulate permissions
>+    $builder->build(
>+        {
>+            source => 'UserPermission',
>+            value  => {
>+                borrowernumber => $patron->borrowernumber,
>+                module_bit     => 1,
>+                code           => 'circulate_remaining_permissions',
>+            },
>+        }
>+    );
>+
>+    $t->get_ok( "//$userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/checkouts" )
>+        ->status_is( 200, 'circulate_remaining_permissions allows checkouts access' )
>+        ->json_is( '' => [], 'No checkouts on the biblio' );
> 
>-    $t->get_ok( "//$userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/checkouts")
>-      ->status_is(200)
>-      ->json_is( '' => [], 'No checkouts on the biblio' );
>+    my $bookings_librarian = $builder->build_object(
>+        {
>+            class => 'Koha::Patrons',
>+            value => { flags => 0 }     # no additional permissions
>+        }
>+    );
>+    $builder->build(
>+        {
>+            source => 'UserPermission',
>+            value  => {
>+                borrowernumber => $bookings_librarian->borrowernumber,
>+                module_bit     => 1,
>+                code           => 'manage_bookings',
>+            },
>+        }
>+    );
>+    $bookings_librarian->set_password( { password => $password, skip_validation => 1 } );
>+    my $bookings_userid = $bookings_librarian->userid;
>+
>+    $t->get_ok( "//$bookings_userid:$password@/api/v1/biblios/" . $biblio->biblionumber . "/checkouts" )
>+        ->status_is( 200, 'manage_bookings allows checkouts access' )
>+        ->json_is( '' => [], 'No checkouts on the biblio' );
> 
>     my $item_1 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber });
>     my $item_2 = $builder->build_sample_item({ biblionumber => $biblio->biblionumber });
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35469: 159882 | 159883 | 159996 | 159997 | 160005 | 160006 | 160007 | 161490 | 161491 | 161492 | 161639 | 161640 | 161641 | 161642 | 162644 | 162645