Bugzilla – Attachment 162646 Details for
Bug 36212
transferbook should not look for items without barcode
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36212: Add check on barcode before searching items
Bug-36212-Add-check-on-barcode-before-searching-it.patch (text/plain), 1.05 KB, created by
Marcel de Rooy
on 2024-03-01 09:41:49 UTC
(
hide
)
Description:
Bug 36212: Add check on barcode before searching items
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-03-01 09:41:49 UTC
Size:
1.05 KB
patch
obsolete
>From 53bb1ae005c09e671faab7e21b714d2d8482e94a Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 1 Mar 2024 09:39:35 +0000 >Subject: [PATCH] Bug 36212: Add check on barcode before searching items >Content-Type: text/plain; charset=utf-8 > >Test plan: >Add an item to your database that has no barcode. >Run t/db_dependent/Circulation.t >It will fail without this patch, pass with this patch. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Circulation.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 109809d4b9..0627b052f7 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -327,7 +327,7 @@ sub transferbook { > my $trigger = $params->{trigger}; > my $messages; > my $dotransfer = 1; >- my $item = Koha::Items->find( { barcode => $barcode } ); >+ my $item = $barcode ? Koha::Items->find( { barcode => $barcode } ) : undef; > > Koha::Exceptions::MissingParameter->throw( > "Missing mandatory parameter: from_branch") >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36212
: 162646