Bugzilla – Attachment 162675 Details for
Bug 36187
Cannot set suggestedby when adding/editing a suggestion from the staff interface
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36187: Corrected set data.patron_id in select_suggestor()
Bug-36187-Corrected-set-datapatronid-in-selectsugg.patch (text/plain), 2.05 KB, created by
Lucas Gass (lukeg)
on 2024-03-01 15:46:47 UTC
(
hide
)
Description:
Bug 36187: Corrected set data.patron_id in select_suggestor()
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-03-01 15:46:47 UTC
Size:
2.05 KB
patch
obsolete
>From 4328d1818f008c072e7a9c2d1935d7c3bb0deaed Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Fri, 1 Mar 2024 15:46:04 +0000 >Subject: [PATCH] Bug 36187: Corrected set data.patron_id in select_suggestor() > >To test: >1. Make a new suggestion in the staff interface and attempt to set the "Created by" patron to someone other than the logged in user. >2. Submit the suggestion. >3. select suggestedby from suggestions where suggestionid = X; ( Where X is the suggestionid ) >4. The value is NULL >5. On suggestion/suggestion.pl the "Suggested by" column is blank. >6. APPLY PATCH >7. Try 1 - 3 again. This time the suggestedby should be correctly set. >--- > .../intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >index 96f5d6ad20..875c0b51b0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt >@@ -1311,8 +1311,8 @@ > "x-koha-embed": "+strings" > }, > success: function (data) { >- var suggested = '<input type="hidden" id="suggestedby" name="suggestedby" value="' + data.borrowernumber + '" />'; >- suggested += '<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=' + data.borrowernumber + '">'; >+ var suggested = '<input type="hidden" id="suggestedby" name="suggestedby" value="' + data.patron_id + '" />'; >+ suggested += '<a href="/cgi-bin/koha/members/moremember.pl?borrowernumber=' + data.patron_id + '">'; > suggested += data.surname.escapeHtml() + ', ' + data.firstname.escapeHtml() + ' (' + data.cardnumber.escapeHtml() + ')'; > suggested += '</a> '; > suggested += data._strings.library_id.str.escapeHtml() + ' (' + data._strings.category_id.str.escapeHtml() + ')'; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36187
:
162520
|
162675
|
162683
|
163972