Bugzilla – Attachment 162679 Details for
Bug 33260
Show message queue on staff interface and make notices printable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33260: Add a patron getter method to Koha::Notice::Message
Bug-33260-Add-a-patron-getter-method-to-KohaNotice.patch (text/plain), 1.96 KB, created by
ByWater Sandboxes
on 2024-03-01 16:41:28 UTC
(
hide
)
Description:
Bug 33260: Add a patron getter method to Koha::Notice::Message
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2024-03-01 16:41:28 UTC
Size:
1.96 KB
patch
obsolete
>From cb9cabca2263b8467408553b22704b5453405ea5 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Tue, 21 Mar 2023 02:47:29 +0000 >Subject: [PATCH] Bug 33260: Add a patron getter method to > Koha::Notice::Message > >Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> >Signed-off-by: kelly <kelly@bywatersolutions.com> >--- > Koha/Notice/Message.pm | 16 ++++++++++++++++ > t/db_dependent/Letters.t | 6 ++++-- > 2 files changed, 20 insertions(+), 2 deletions(-) > >diff --git a/Koha/Notice/Message.pm b/Koha/Notice/Message.pm >index b7e30e509f..fd81d0178e 100644 >--- a/Koha/Notice/Message.pm >+++ b/Koha/Notice/Message.pm >@@ -65,6 +65,22 @@ EOS > > } > >+=head3 patron >+ >+ my $patron = $message->patron; >+ >+Returns the Koha::Patron object for the recipient of the queued message >+ >+=cut >+ >+sub patron { >+ my ( $self ) = @_; >+ >+ $self->{_patron} ||= Koha::Patrons->find( $self->borrowernumber ); >+ >+ return $self->{_patron}; >+} >+ > =head3 type > > =cut >diff --git a/t/db_dependent/Letters.t b/t/db_dependent/Letters.t >index ade28f89ad..3e0659ac11 100755 >--- a/t/db_dependent/Letters.t >+++ b/t/db_dependent/Letters.t >@@ -18,7 +18,7 @@ > # along with Koha; if not, see <http://www.gnu.org/licenses>. > > use Modern::Perl; >-use Test::More tests => 99; >+use Test::More tests => 100; > use Test::MockModule; > use Test::Warn; > use Test::Exception; >@@ -155,7 +155,9 @@ is( $messages->[0]->{failure_code}, '', 'Failure code for successful message cor > > # Setting time_queued to something else than now > my $yesterday = dt_from_string->subtract( days => 1 ); >-Koha::Notice::Messages->find($messages->[0]->{message_id})->time_queued($yesterday)->store; >+my $message_obj = Koha::Notice::Messages->find($messages->[0]->{message_id})->time_queued($yesterday)->store; >+my $patron_obj = Koha::Patrons->find( $borrowernumber ); >+is_deeply( $message_obj->patron, $patron_obj, "Koha::Notice::Message->patron sub correctly returns patron object"); > > # SendQueuedMessages > >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33260
:
148437
|
148438
|
148439
|
148440
|
148943
|
149009
|
149413
|
149581
|
149593
|
149594
|
149595
|
149596
|
149597
|
149598
|
150346
|
150347
|
154927
|
154928
|
157383
|
157384
|
157385
|
157386
|
158852
|
158853
|
158854
|
158855
|
162570
|
162571
|
162572
|
162573
|
162574
|
162624
|
162625
|
162677
|
162678
|
162679
|
162680
|
162681
|
164783
|
164784
|
164785
|
164786
|
164787
|
165238
|
165239
|
165717
|
165939
|
165946
|
165947
|
165948
|
165949
|
165950
|
165951
|
166020
|
166178
|
166335
|
166336
|
166337
|
166338
|
166339
|
166340
|
166341
|
166342
|
166343
|
166344
|
166345
|
166362
|
166363
|
166364
|
166365
|
166366
|
166367
|
166368
|
166369
|
166370
|
166371
|
166372
|
166373
|
167909
|
167910
|
167911
|
167912
|
167913
|
167914
|
167915
|
167916
|
167917
|
167918
|
167919
|
167920
|
172247
|
172248
|
172303
|
172307
|
172308
|
172309
|
172310
|
172311
|
172312
|
172313
|
172314
|
172315
|
172316
|
172317
|
172318
|
172319
|
172320
|
172321
|
172322
|
172342
|
172343
|
172344
|
172345
|
172346
|
172347
|
172348
|
172349
|
172350
|
172351
|
172352
|
172353
|
172354
|
172355
|
172356
|
172357
|
172358
|
172359
|
172379
|
175501
|
175502
|
175503
|
175504
|
175505
|
175506
|
175507
|
175508
|
175509
|
175510
|
175511
|
175512
|
175513
|
175514
|
175515
|
175516
|
175517
|
175518
|
175519
|
175520
|
175521
|
175522
|
175523
|
175524
|
175525
|
175530
|
175537
|
175538
|
175539
|
175540
|
175541
|
175542
|
175543
|
175544
|
175545
|
175546
|
175547
|
175548
|
175549
|
175550
|
175551
|
175552
|
175553
|
175554
|
175555
|
175556
|
175557
|
175558
|
175559
|
175560
|
175561
|
175562
|
175563
|
175730
|
175731
|
175732
|
175733
|
175734
|
175735
|
175736
|
175737
|
175738
|
175739
|
175740
|
175741
|
175742
|
175743
|
175744
|
175745
|
175746
|
175747
|
175748
|
175749
|
175750
|
175751
|
175752
|
175753
|
175754
|
175755
|
175756
|
178733
|
178734
|
178735
|
178736
|
178737
|
178738
|
178739
|
178740
|
178741
|
178742
|
178743
|
178744
|
178745
|
178746
|
178747
|
178748
|
178749
|
178750
|
178751
|
178752
|
178753
|
178754
|
178755
|
178756
|
178757
|
178758
|
178759