Bugzilla – Attachment 162687 Details for
Bug 35950
Move the handling of statistics patron logic out of CanBookBeIssued
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35950: Adjust tests
Bug-35950-Adjust-tests.patch (text/plain), 2.05 KB, created by
Andrew Fuerste-Henry
on 2024-03-01 18:42:19 UTC
(
hide
)
Description:
Bug 35950: Adjust tests
Filename:
MIME Type:
Creator:
Andrew Fuerste-Henry
Created:
2024-03-01 18:42:19 UTC
Size:
2.05 KB
patch
obsolete
>From 85afccd0cfe4e304b562535de40dc2ab15c2f0a1 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Thu, 29 Feb 2024 21:03:13 +0000 >Subject: [PATCH] Bug 35950: Adjust tests > >Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> >--- > t/db_dependent/Circulation.t | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) > >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 27a5815434b..88bb88a9483 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -2434,7 +2434,7 @@ subtest 'CanBookBeIssued + Koha::Patron->is_debarred|has_overdues' => sub { > }; > > subtest 'CanBookBeIssued + Statistic patrons "X"' => sub { >- plan tests => 14; >+ plan tests => 13; > > my $library = $builder->build_object( { class => 'Koha::Libraries' } ); > my $patron_category_x = $builder->build_object( >@@ -2482,10 +2482,6 @@ subtest 'CanBookBeIssued + Statistic patrons "X"' => sub { > $item_2->discard_changes; > ok( $item_2->onloan, "Item is checked out" ); > >- ( $error, $question, $alerts ) = CanBookBeIssued( $patron, $item_2->barcode ); >- $item_2->discard_changes; >- ok( !$item_2->onloan, "Checked out item is returned" ); >- > my $item_3 = $builder->build_sample_item( { library => $library->branchcode } ); > CanBookBeIssued( $patron, $item_3->barcode ); > $item_3->discard_changes; >@@ -2497,7 +2493,7 @@ subtest 'CanBookBeIssued + Statistic patrons "X"' => sub { > is( Koha::Statistics->search( { itemnumber => $item_4->itemnumber } )->count, 1, 'Issue should be recorded in statistics table for item 4.' ); > CanBookBeIssued( $patron, $item_4->barcode ); > $item_4->discard_changes; >- is( Koha::Statistics->search( { itemnumber => $item_4->itemnumber } )->count, 3, 'Issue, return, and localuse should be recorded in statistics table for item 4.' ); >+ is( Koha::Statistics->search( { itemnumber => $item_4->itemnumber } )->count, 2, 'Issue and localuse should be recorded in statistics table for item 4.' ); > > # TODO There are other tests to provide here > }; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35950
:
162616
|
162617
|
162618
|
162686
|
162687
|
162966
|
162967