Bugzilla – Attachment 162696 Details for
Bug 35924
The 'checkin slip' button should not be available for patrons whose privacy is set to never
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35924: Hide the print checkins button on the patron screens for patron's who always anonymize
Bug-35924-Hide-the-print-checkins-button-on-the-pa.patch (text/plain), 1.96 KB, created by
Victor Grousset/tuxayo
on 2024-03-03 00:10:02 UTC
(
hide
)
Description:
Bug 35924: Hide the print checkins button on the patron screens for patron's who always anonymize
Filename:
MIME Type:
Creator:
Victor Grousset/tuxayo
Created:
2024-03-03 00:10:02 UTC
Size:
1.96 KB
patch
obsolete
>From cf66005e3920051f95545ba0f5415bdd73f90bee Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 29 Jan 2024 06:51:14 -0500 >Subject: [PATCH] Bug 35924: Hide the print checkins button on the patron > screens for patron's who always anonymize > >If a patron anonymizes their checkins, the checkin slip cannot retrieve any info to print the checkin slip. We should not show the button in this scenario > >Test Plan: >1) Set a patron's privacy to "Never" >2) Note the "Print checkin slip" option in the Print button on the > patrons toolbar displays >3) Apply this patch >4) Reload the page >5) Note the option is now missing >6) Set the patron's privacy to "Forever" or "Default" >7) Reload the page >8) Note the print checkins option is back! > >Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >index f1965dd6b5..8b8c867cb4 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc >@@ -30,7 +30,9 @@ > [% IF patron.has_overdues %] > <li><a id="print_overdues" href="#">Print overdues</a></li> > [% END %] >- <li><a class="printslip" data-code="checkinslip" href="#">Print checkin slip</a></li> >+ [% IF patron.privacy < 2 %] >+ <li><a class="printslip" data-code="checkinslip" href="#">Print checkin slip</a></li> >+ [% END %] > [% FOREACH notice IN Notices.GetTemplates( 'patron_slip' ) %] > <li><a class="printslip" data-code="[% notice.code | html %]" href="#">Print [% notice.name | html %]</a></li> > [% END %] >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35924
:
161592
|
161593
|
161734
|
161735
| 162696 |
162697
|
162698