Attachment 162746 Details for Bug 35100 – Bug 35100: (follow-up) Fix test

[patch] Bug 35100: (follow-up) Fix test

Bug-35100-follow-up-Fix-test.patch (text/plain), 1.31 KB, created by Nick Clemens (kidclamp) on 2024-03-05 12:41:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-03-05 12:41:14 UTC

Size: 1.31 KB

patch

obsolete

>From d144ea1a40a6458a204ffe75c920df8da761cf30 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 5 Mar 2024 12:31:12 +0000
>Subject: [PATCH] Bug 35100: (follow-up) Fix test
>
>Previous patches changed the return values, just needed to update expectations
>---
> t/db_dependent/SIP/Transaction.t | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/SIP/Transaction.t b/t/db_dependent/SIP/Transaction.t
>index 56a810a7360..fdb595c6151 100755
>--- a/t/db_dependent/SIP/Transaction.t
>+++ b/t/db_dependent/SIP/Transaction.t
>@@ -406,13 +406,15 @@ subtest do_checkin => sub {
>     is( $patron->checkouts->count, 0, 'Checkin should have been done successfully' );
> 
>     my $result = $ci_transaction->do_checkin( $library2->branchcode, undef );
>+    my $transfer = $item->get_transfer;
>     is( $ci_transaction->alert_type, '04', "Checkin of item no issued at another branch succeeds" );
>     is_deeply(
>         $result,
>         {
>             messages => {
>                 'NotIssued'       => $item->barcode,
>-                'WasTransfered'   => $library->branchcode,
>+                'WasTransfered'   => $transfer->branchtransfer_id,
>+                'TransferTo'      => $library->branchcode,
>                 'TransferTrigger' => 'ReturnToHome'
>             }
>         },
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35100: 160514 | 160515 | 160557 | 160558 | 160575 | 160623 | 160628 | 160641 | 160642 | 160643 | 160647 | 160648 | 160687 | 160688 | 160689 | 160690 | 162740 | 162741 | 162742 | 162743 | 162744 | 162745 | 162746 | 162747 | 162757 | 162758 | 162759 | 162760 | 162761 | 162762 | 165096 | 165097 | 165098 | 165099 | 165100 | 165101 | 168273 | 168274 | 168275 | 168276 | 168277 | 168278 | 169347 | 169348 | 169349 | 169350 | 169351 | 169352 | 169353 | 171530 | 171531 | 171532 | 171533 | 171534 | 171535 | 171559 | 171560 | 171561 | 171562 | 171563 | 171564