Bugzilla – Attachment 162749 Details for
Bug 36193
CSRF - Code review missed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36193: cud- treatment for cash_registers.pl
Bug-36193-cud--treatment-for-cashregisterspl.patch (text/plain), 6.67 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-03-05 14:24:04 UTC
(
hide
)
Description:
Bug 36193: cud- treatment for cash_registers.pl
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-03-05 14:24:04 UTC
Size:
6.67 KB
patch
obsolete
>From fb87070f4021c5b7650fc63992f56ee3bd4ace37 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Tue, 5 Mar 2024 11:23:36 -0300 >Subject: [PATCH] Bug 36193: cud- treatment for cash_registers.pl > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > admin/cash_registers.pl | 8 +-- > .../prog/en/modules/admin/cash_registers.tt | 51 +++++++++++++++++-- > 2 files changed, 51 insertions(+), 8 deletions(-) > >diff --git a/admin/cash_registers.pl b/admin/cash_registers.pl >index 78abf749ad9..94eebbd5a0b 100755 >--- a/admin/cash_registers.pl >+++ b/admin/cash_registers.pl >@@ -99,7 +99,7 @@ elsif ( $op eq 'cud-add_validate' ) { > $op = 'list'; > } > >-elsif ( $op eq 'archive' ) { >+elsif ( $op eq 'cud-archive' ) { > if ($registerid) { > try { > my $cash_register = Koha::Cash::Registers->find($registerid); >@@ -113,7 +113,7 @@ elsif ( $op eq 'archive' ) { > } > $op = 'list'; > } >-elsif ( $op eq 'unarchive' ) { >+elsif ( $op eq 'cud-unarchive' ) { > if ($registerid) { > try { > my $cash_register = Koha::Cash::Registers->find($registerid); >@@ -127,7 +127,7 @@ elsif ( $op eq 'unarchive' ) { > $op = 'list'; > } > >-elsif ( $op eq 'make_default' ) { >+elsif ( $op eq 'cud-make_default' ) { > if ($registerid) { > try { > my $cash_register = Koha::Cash::Registers->find($registerid); >@@ -140,7 +140,7 @@ elsif ( $op eq 'make_default' ) { > } > $op = 'list'; > } >-elsif ( $op eq 'drop_default' ) { >+elsif ( $op eq 'cud-drop_default' ) { > if ($registerid) { > try { > my $cash_register = Koha::Cash::Registers->find($registerid); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cash_registers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cash_registers.tt >index 81a2a09c21d..06ef94bcaef 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cash_registers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cash_registers.tt >@@ -193,14 +193,34 @@ > <td class="actions"> > <a class="btn btn-default btn-xs" href="cash_registers.pl?op=add_form&id=[% cash_register.id | uri %]"><i class="fa-solid fa-pencil" aria-hidden="true"></i> Edit</a> > [% IF cash_register.branch_default %] >- <a class="btn btn-default btn-xs" href="cash_registers.pl?op=drop_default&id=[% cash_register.id | uri %]"><i class="fa fa-archive"></i> Drop default</a> >+ <form id="drop_default_[% cash_register.id | html %]" method="post" action="/cgi-bin/koha/admin/cash_registers.pl"> >+ [% INCLUDE 'csrf-token.inc' %] >+ <input type="hidden" name="op" value="cud-drop_default" /> >+ <input type="hidden" name="id" value="[% cash_register.id | html %]" /> >+ </form> >+ <a id="drop_default_button" class="btn btn-default btn-xs" href="#" data-id="[% cash_register.id | html %]"><i class="fa fa-archive"></i> Drop default</a> > [% ELSE %] >- <a class="btn btn-default btn-xs" href="cash_registers.pl?op=make_default&id=[% cash_register.id | uri %]"><i class="fa fa-archive"></i> Make default</a> >+ <form id="make_default_[% cash_register.id | html %]" method="post" action="/cgi-bin/koha/admin/cash_registers.pl"> >+ [% INCLUDE 'csrf-token.inc' %] >+ <input type="hidden" name="op" value="cud-make_default" /> >+ <input type="hidden" name="id" value="[% cash_register.id | html %]" /> >+ </form> >+ <a class="btn btn-default btn-xs make_default_button" href="#" data-id="[% cash_register.id | html %]"><i class="fa fa-archive"></i> Make default</a> > [% END %] >- <a class="btn btn-default btn-xs" href="cash_registers.pl?op=archive&id=[% cash_register.id | uri %]"><i class="fa fa-archive"></i> Archive</a> >+ <form id="archive_[% cash_register.id | html %]" method="post" action="/cgi-bin/koha/admin/cash_registers.pl"> >+ [% INCLUDE 'csrf-token.inc' %] >+ <input type="hidden" name="op" value="cud-archive" /> >+ <input type="hidden" name="id" value="[% cash_register.id | html %]" /> >+ </form> >+ <a class="btn btn-default btn-xs archive_button" href="#" data-id="[% cash_register.id | html %]"><i class="fa fa-archive"></i> Archive</a> > </td> > [% ELSE %] >- <td class="actions"><a class="btn btn-default btn-xs" href="cash_registers.pl?op=unarchive&id=[% cash_register.id | uri %]"><i class="fa fa-trash-can-restore"></i> Restore</a></td> >+ <form id="unarchive_[% cash_register.id | html %]" method="post" action="/cgi-bin/koha/admin/cash_registers.pl"> >+ [% INCLUDE 'csrf-token.inc' %] >+ <input type="hidden" name="op" value="cud-unarchive" /> >+ <input type="hidden" name="id" value="[% cash_register.id | html %]" /> >+ </form> >+ <td class="actions"><a class="btn btn-default btn-xs unarchive_button" href="#" data-id="[% cash_register.id | html %]"><i class="fa fa-trash-can-restore"></i> Restore</a></td> > [% END %] > </tr> > [% END %] >@@ -257,6 +277,29 @@ > filterDataTable( crtable, 2, opt ); > }); > >+ $("#drop_default_button").on("click", function(e){ >+ e.preventDefault(); >+ var id = $(this).data('id'); >+ $('#drop_default_'+id).submit(); >+ }); >+ >+ $(".make_default_button").on("click", function(e){ >+ e.preventDefault(); >+ var id = $(this).data('id'); >+ $('#make_default_'+id).submit(); >+ }); >+ >+ $(".archive_button").on("click", function(e){ >+ e.preventDefault(); >+ var id = $(this).data('id'); >+ $('#archive_'+id).submit(); >+ }); >+ >+ $(".unarchive_button").on("click", function(e){ >+ e.preventDefault(); >+ var id = $(this).data('id'); >+ $('#unarchive_'+id).submit(); >+ }); > }); > </script> > [% END %] >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36193
:
162684
|
162733
|
162734
|
162749
|
162750
|
162751
|
162752
|
162755
|
162769
|
162770
|
162771
|
162772
|
162773
|
162774
|
162775
|
162776
|
162777
|
162784
|
162830
|
162831
|
162837