Attachment 162843 Details for Bug 36215 – Bug 36215: Remove limit on fetching bookings

[patch] Bug 36215: Remove limit on fetching bookings

Bug-36215-Remove-limit-on-fetching-bookings.patch (text/plain), 1.89 KB, created by Martin Renvoize (ashimema) on 2024-03-06 17:07:09 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-03-06 17:07:09 UTC

Size: 1.89 KB

patch

obsolete

>From 239d05a49b6f9bc2c929962db92eab4ebc9117cc Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 6 Mar 2024 17:05:31 +0000
>Subject: [PATCH] Bug 36215: Remove limit on fetching bookings
>
>This removes the paging from the bookings request so we take into
>account all bookings.
>
>We may want to replace this with date bounded paging in the future, but
>lets not try to optimise until we need to.
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt | 2 +-
> koha-tmpl/intranet-tmpl/prog/js/place_booking_modal.js   | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt
>index a8f51d3e197..fb7ec24c0a7 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt
>@@ -81,7 +81,7 @@
>             type: 'GET'
>         });
>         var bookings = $.ajax({
>-            url: '/api/v1/biblios/[% biblionumber | uri %]/bookings',
>+            url: '/api/v1/biblios/[% biblionumber | uri %]/bookings&_per_page=-1',
>             headers: { 'x-koha-embed': 'patron' },
>             dataType: 'json',
>             type: 'GET',
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/place_booking_modal.js b/koha-tmpl/intranet-tmpl/prog/js/place_booking_modal.js
>index 946be01e3cd..832ee2a6a1d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/place_booking_modal.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/place_booking_modal.js
>@@ -124,7 +124,7 @@ $('#placeBookingModal').on('show.bs.modal', function(e) {
> 
>         // Fetch list of existing bookings
>         let bookingsFetch = $.ajax({
>-            url: '/api/v1/bookings?biblio_id=' + biblionumber,
>+            url: '/api/v1/bookings?biblio_id=' + biblionumber + '&_per_page=-1',
>             dataType: 'json',
>             type: 'GET'
>         });
>-- 
>2.44.0

Actions: View | Diff | Splinter Review

Attachments on bug 36215: 162843 | 162846 | 163051