Bugzilla – Attachment 162850 Details for
Bug 34823
Do not show item group drop-down if there are no item groups
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 34823: Do not show Item group dropdown if there are no item groups
Bug-34823-Do-not-show-Item-group-dropdown-if-there.patch (text/plain), 1.96 KB, created by
Caroline Cyr La Rose
on 2024-03-06 19:03:04 UTC
(
hide
)
Description:
Bug 34823: Do not show Item group dropdown if there are no item groups
Filename:
MIME Type:
Creator:
Caroline Cyr La Rose
Created:
2024-03-06 19:03:04 UTC
Size:
1.96 KB
patch
obsolete
>From f963b2029f2afc89a4cc674366b789641412d628 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Wed, 6 Mar 2024 18:41:04 +0000 >Subject: [PATCH] Bug 34823: Do not show Item group dropdown if there are no > item groups > >To test: >1. Enable EnableItemGroups and EnableItemGroupHolds >2. Go to the OPAC and log in as a patron >3. Go to any record that doesn't have grouped items and try to place a hold >4. Click on "Show more options" >5. See "Request specific item group:" and dropdown >6. APPLY PATCH >7. Try again, this time if the record has no item groups you should not see the dropdown at all. > >Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >index 5f3ea2691b..6d62b9eb6d 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >@@ -314,7 +314,7 @@ > [% END %] > > [% UNLESS bibitemloo.forced_hold_level && ( bibitemloo.forced_hold_level == 'item' || bibitemloo.forced_hold_level == 'record' ) %] >- [% IF Koha.Preference('EnableItemGroupHolds') && bibitemloo.object.item_groups %] >+ [% IF Koha.Preference('EnableItemGroupHolds') && bibitemloo.object.item_groups.count %] > <li> > <label for="itemtype">Request specific item group:</label> > <select name="item_group_id_[% bibitemloo.biblionumber | html %]" id="item_group_id_[% bibitemloo.biblionumber | html %]"> >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 34823
:
162847
|
162850
|
166610