Attachment 162855 Details for Bug 30745 – Bug 30745 : Fix undefined value error while using zebra

[patch] Bug 30745 : Fix undefined value error while using zebra

Bug-30745--Fix-undefined-value-error-while-using-z.patch (text/plain), 1.62 KB, created by Phan Tung Bui on 2024-03-06 20:15:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Phan Tung Bui

Created: 2024-03-06 20:15:48 UTC

Size: 1.62 KB

patch

obsolete

>From b3a5468c55548f78ce230ddcee72bcb720128f2a Mon Sep 17 00:00:00 2001
>From: Phan Tung Bui <phan-tung.bui@inlibro.com>
>Date: Wed, 6 Mar 2024 14:43:13 -0500
>Subject: [PATCH] Bug 30745 : Fix undefined value error while using zebra
>
>---
> labels/label-item-search.pl | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
>diff --git a/labels/label-item-search.pl b/labels/label-item-search.pl
>index 2a55f331c5..f23236cc62 100755
>--- a/labels/label-item-search.pl
>+++ b/labels/label-item-search.pl
>@@ -85,15 +85,16 @@ if ( $op eq "cud-do_search" ) {
>         undef, undef, $query_type, undef
>     );
> 
>-    if (!defined $error && @{$results->{biblioserver}{RECORDS}} ) {
>-        $show_results = grep { defined $_ } @{$results->{biblioserver}{RECORDS}};
>-        $marcresults = [ grep { defined $_ } @{$results->{biblioserver}{RECORDS}} ];
>-        $total_hits = $results->{biblioserver}{hits};
>-    }
>-    else {
>-        Koha::Logger->get->warn("ERROR label-item-search: no results from simple_search_compat");
>-
>-        # leave $show_results undef
>+    if (!$results->{biblioserver}{RECORDS}) {
>+        Koha::Logger->get->warn("ERROR label-item-search: no records found");
>+    } else {
>+        if (defined $results->{biblioserver}{RECORDS}) {
>+            $show_results = grep { defined $_ } @{$results->{biblioserver}{RECORDS}};
>+            $marcresults = [ grep { defined $_ } @{$results->{biblioserver}{RECORDS}} ];
>+            $total_hits = $results->{biblioserver}{hits};
>+        } else {
>+            Koha::Logger->get->warn("ERROR label-item-search: no results from simple_search_compat");
>+        }
>     }
> }
> 
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 30745: 134952 | 134953 | 135784 | 135785 | 135966 | 135967 | 157192 | 157194 | 157195 | 157934 | 162855 | 163955 | 170677 | 170678 | 170679 | 170680 | 170681 | 170682 | 170683 | 170684 | 170729 | 170730 | 170731 | 170732 | 170733 | 171002 | 171003 | 171004 | 171005 | 171006 | 173280 | 173943 | 173944 | 173945 | 173946 | 173947 | 174486 | 174487 | 174488 | 174489 | 174490 | 174491