Bugzilla – Attachment 162935 Details for
Bug 36274
OPAC suggestions form doesn't display
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36274: Correct links leading to purchase suggestion page
Bug-36274-Correct-links-leading-to-purchase-sugges.patch (text/plain), 4.83 KB, created by
Lucas Gass (lukeg)
on 2024-03-07 23:16:32 UTC
(
hide
)
Description:
Bug 36274: Correct links leading to purchase suggestion page
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-03-07 23:16:32 UTC
Size:
4.83 KB
patch
obsolete
>From 8c580aa6dac7d81d04f81177781b64077ff0e1e0 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Thu, 7 Mar 2024 23:09:56 +0000 >Subject: [PATCH] Bug 36274: Correct links leading to purchase suggestion page > >To test: >1. APPLY PATCH >2. As a logged in OPAC user go to 'Your account' > Purchase suggestion. The form should display. >3. Make a suggestion and confirm it works. >4. Try to make a suggestion using title, author, isbn information from an item that already exists. >5. See the "A similar document already exists:" warning. Confirm the suggestion anyways. >6. Set MaxTotalSuggestions to 4 and NumberOfSuggestionDays to 2. Make sure you can still navigate to the purchase suggestion form. >7. Do an OPAC search that will yield no results as a logged in user. >8. Click the "Make a purchase suggestion" link, making sure it works. >9. Turn on AnonSuggestions and log out of the OPAC. >10. Do an OPAC search that will yield no results. Again click the "Make a purchase suggestion", confirm it works. >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 4 ++-- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index 043b1bbc69..1e16195fe7 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -557,9 +557,9 @@ > <ul> > [% IF suggestion %] > [% IF Koha.Preference( 'AnonSuggestions' ) == 1 %] >- <li>Make a <a href="/cgi-bin/koha/opac-suggestions.pl?op=add">purchase suggestion</a></li> >+ <li>Make a <a href="/cgi-bin/koha/opac-suggestions.pl?op=add_form">purchase suggestion</a></li> > [% ELSIF loggedinusername %] >- <li>Make a <a href="/cgi-bin/koha/opac-suggestions.pl?op=add">purchase suggestion</a></li> >+ <li>Make a <a href="/cgi-bin/koha/opac-suggestions.pl?op=add_form">purchase suggestion</a></li> > [% END %] > [% END %] > [% IF Koha.Preference( 'ILLModule' ) == 1 && loggedinusername %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >index 2be316bc6f..6bf1a4facb 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >@@ -382,7 +382,7 @@ > [% ELSIF ( Koha.Preference('MaxOpenSuggestions') != '' && patrons_pending_suggestions_count >= Koha.Preference('MaxOpenSuggestions') ) %] > <p class="TooManySuggestionsText">You have reached your limit for suggestions you can place at this time ([% Koha.Preference('MaxOpenSuggestions') | html %]).</br>Once the library has processed those suggestions you will be able to place more.</p> > [% ELSE %] >- <a class="btn btn-link new" href="/cgi-bin/koha/opac-suggestions.pl?op=add"><i class="fa fa-plus" aria-hidden="true"></i> New purchase suggestion</a> >+ <a class="btn btn-link new" href="/cgi-bin/koha/opac-suggestions.pl?op=add_form"><i class="fa fa-plus" aria-hidden="true"></i> New purchase suggestion</a> > [% END %] > </div> > [% END %] >@@ -521,7 +521,7 @@ > [% ELSIF ( Koha.Preference('MaxOpenSuggestions') != '' && patrons_pending_suggestions_count >= Koha.Preference('MaxOpenSuggestions') ) %] > <p class="TooManySuggestionsText">You have reached your limit for suggestions you can place at this time.</br>Once the library has processed those suggestions you will be able to place more.</p> > [% ELSE %] >- <p><a class="btn btn-link new" href="/cgi-bin/koha/opac-suggestions.pl?op=add"><i class="fa fa-plus" aria-hidden="true"></i> New purchase suggestion</a></p> >+ <p><a class="btn btn-link new" href="/cgi-bin/koha/opac-suggestions.pl?op=add_form"><i class="fa fa-plus" aria-hidden="true"></i> New purchase suggestion</a></p> > [% END %] > [% END %] > [% END # / IF suggestions.size %] >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36274
:
162907
|
162935
|
162994
|
163166