Attachment 162940 Details for Bug 33268 – Bug 33268: (QA follow-up): tidy up code

[patch] Bug 33268: (QA follow-up): tidy up code

Bug-33268-QA-follow-up-tidy-up-code.patch (text/plain), 1.74 KB, created by Victor Grousset/tuxayo on 2024-03-08 04:06:44 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2024-03-08 04:06:44 UTC

Size: 1.74 KB

patch

obsolete

>From 45bf01a36d15ddf2dd5874c0c9c2a460b2fea23e Mon Sep 17 00:00:00 2001
>From: Victor Grousset/tuxayo <victor@tuxayo.net>
>Date: Tue, 5 Mar 2024 23:29:25 +0100
>Subject: [PATCH] Bug 33268: (QA follow-up): tidy up code
>
>---
> ...dd_rules_to_preserve_current_overlay_rules_behavior.pl | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_33268-add_rules_to_preserve_current_overlay_rules_behavior.pl b/installer/data/mysql/atomicupdate/bug_33268-add_rules_to_preserve_current_overlay_rules_behavior.pl
>index 88d4a9e334..b755944958 100755
>--- a/installer/data/mysql/atomicupdate/bug_33268-add_rules_to_preserve_current_overlay_rules_behavior.pl
>+++ b/installer/data/mysql/atomicupdate/bug_33268-add_rules_to_preserve_current_overlay_rules_behavior.pl
>@@ -18,14 +18,14 @@ return {
>                 `module` IN (SELECT `module` FROM `marc_overlay_rules` WHERE `filter` = "*") AND
>                 `filter` NOT IN (SELECT `filter` FROM `marc_overlay_rules` WHERE `tag` = "*")
>         };
>-        my @results = $dbh->selectall_array( $query );
>-        for my $result ( @results ) {
>-            my ($module, $filter) = @{$result};
>+        my @results = $dbh->selectall_array($query);
>+        for my $result (@results) {
>+            my ( $module, $filter ) = @{$result};
>             $query = q{
>                 INSERT INTO `marc_overlay_rules`(`tag`, `module`, `filter`, `add`, `append`, `remove`, `delete`)
>                 VALUES(?, ?, ?, ?, ?, ?, ?)
>             };
>-            $dbh->do($query, undef, '*', $module, $filter, 1, 1, 1, 1);
>+            $dbh->do( $query, undef, '*', $module, $filter, 1, 1, 1, 1 );
>         }
>         say $out "Added record overlay rules to preserve current behavior";
>     },
>-- 
>2.44.0

Actions: View | Diff | Splinter Review

Attachments on bug 33268: 158956 | 159004 | 159058 | 159160 | 159161 | 159518 | 159519 | 160017 | 160018 | 162764 | 162766 | 162767 | 162785 | 162786 | 162796 | 162797 | 162798 | 162799 | 162800 | 162801 | 162802 | 162803 | 162804 | 162805 | 162936 | 162937 | 162938 | 162939 | 162940