Bugzilla – Attachment 163012 Details for
Bug 36013
update_totalissues.pl should not log
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36013: update_totalissues.pl should not log
Bug-36013-updatetotalissuespl-should-not-log.patch (text/plain), 1.54 KB, created by
David Nind
on 2024-03-09 20:52:44 UTC
(
hide
)
Description:
Bug 36013: update_totalissues.pl should not log
Filename:
MIME Type:
Creator:
David Nind
Created:
2024-03-09 20:52:44 UTC
Size:
1.54 KB
patch
obsolete
>From 020f13c843602a0c25a845a9a7e7fc02c2000b9d Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 7 Feb 2024 11:10:24 +0100 >Subject: [PATCH] Bug 36013: update_totalissues.pl should not log > >Even when CataloguingLog is on, misc/cronjobs/update_totalissues.pl should not log the changes. >It is useless and takes database space. > >Do like bulkmarcimport.pl : >https://git.koha-community.org/Koha-community/Koha/src/branch/23.11.x/misc/migration_tools/bulkmarcimport.pl#L165 > >Test plan : >1) Enable system preference CataloguingLog >2) Perform some issues and returns >3) Run : misc/cronjobs/update_totalissues.pl --use-stats --commit=1000 -v >4) Go to Tools > Log viewer >5) Check there are no new cataloguing logs > >Signed-off-by: Magnus Enger <magnus@libriotech.no> >Works as advertised. Before the patch, running the script adds one >entry to action_logs per record, with the patch nothing is logged. >Signed-off-by: David Nind <david@davidnind.com> >--- > misc/cronjobs/update_totalissues.pl | 4 ++++ > 1 file changed, 4 insertions(+) > >diff --git a/misc/cronjobs/update_totalissues.pl b/misc/cronjobs/update_totalissues.pl >index eee8fdef62..8836b40273 100755 >--- a/misc/cronjobs/update_totalissues.pl >+++ b/misc/cronjobs/update_totalissues.pl >@@ -92,6 +92,10 @@ if ( not $result or $want_help ) { > usage(); > } > >+# Disable logging for the biblios and authorities >+$ENV{OVERRIDE_SYSPREF_CataloguingLog} = 0; >+$ENV{OVERRIDE_SYSPREF_AuthoritiesLog} = 0; >+ > cronlogaction({ info => $command_line_options }); > > my $dbh = C4::Context->dbh; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36013
:
161797
|
162957
| 163012