Bugzilla – Attachment 163026 Details for
Bug 36235
System preferences chopping everything after a semicolon.
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36235: Encode system preference data with encodeURIComponent
Bug-36235-Encode-system-preference-data-with-encod.patch (text/plain), 1.68 KB, created by
Jonathan Druart
on 2024-03-11 12:25:13 UTC
(
hide
)
Description:
Bug 36235: Encode system preference data with encodeURIComponent
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-03-11 12:25:13 UTC
Size:
1.68 KB
patch
obsolete
>From f3951f4cfd047b2c777e69acbcece3d34f1d8c33 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Tue, 5 Mar 2024 16:25:46 +0000 >Subject: [PATCH] Bug 36235: Encode system preference data with > encodeURIComponent > >To test: >1. Add some data to a freetext system preference like IntranetUserJS or AdditionalFieldsInZ3950ResultAuthSearch that includes a semicolon; >2. Save the pref and reload the page or check the DB. Everything after the semicolon is removed. >3. Apply patch, try again. Data should remain as is. > >Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> >Signed-off-by: David Nind <david@davidnind.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .../prog/js/fetch/system-preferences-api-client.js | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/fetch/system-preferences-api-client.js b/koha-tmpl/intranet-tmpl/prog/js/fetch/system-preferences-api-client.js >index 1b8634951b6..e2b9bcbac8a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/fetch/system-preferences-api-client.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/fetch/system-preferences-api-client.js >@@ -32,7 +32,7 @@ export class SysprefAPIClient extends HttpClient { > .map(variable => > sysprefs[variable].length > ? sysprefs[variable].map(value => >- "%s=%s".format(variable, value) >+ "%s=%s".format(variable, encodeURIComponent(value)) > ) > : "%s=".format(variable) > ) >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36235
:
162778
|
162975
|
163011
| 163026