Attachment 163181 Details for Bug 36118 – Bug 36118: Tidy changed code block

[patch] Bug 36118: Tidy changed code block

Bug-36118-Tidy-changed-code-block.patch (text/plain), 1.62 KB, created by Pedro Amorim on 2024-03-15 09:12:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-03-15 09:12:28 UTC

Size: 1.62 KB

patch

obsolete

>From 12cdce022917741e5fdb77adb50a1746a6943b40 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 29 Feb 2024 10:35:23 +0000
>Subject: [PATCH] Bug 36118: Tidy changed code block
>
>Simple tidy of the codeblock we added a line to so we get through the
>tidy requirements of the QA script.
>---
> Koha/Illrequest/Logger.pm | 20 +++++++++++---------
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
>diff --git a/Koha/Illrequest/Logger.pm b/Koha/Illrequest/Logger.pm
>index 2e8f3b14fdc..c6c0ad74e35 100644
>--- a/Koha/Illrequest/Logger.pm
>+++ b/Koha/Illrequest/Logger.pm
>@@ -258,16 +258,18 @@ sub get_request_logs {
>     foreach my $alias(@{$aliases}) {
>         $alias_hash->{$alias->{authorised_value}} = $alias;
>     }
>-    foreach my $log(@{$logs}) {
>-        $log->{patron} = Koha::Patrons->find( $log->{user} );
>+    foreach my $log ( @{$logs} ) {
>+        $log->{patron}       = Koha::Patrons->find( $log->{user} );
>         $log->{notice_types} = $notice_hash;
>-        $log->{aliases} = $alias_hash;
>-        $log->{info} = from_json($log->{info});
>-        $log->{template} = $self->get_log_template({
>-            request => $request,
>-            origin => $log->{info}->{log_origin},
>-            action => $log->{action}
>-        });
>+        $log->{aliases}      = $alias_hash;
>+        $log->{info}         = from_json( $log->{info} );
>+        $log->{template}     = $self->get_log_template(
>+            {
>+                request => $request,
>+                origin  => $log->{info}->{log_origin},
>+                action  => $log->{action}
>+            }
>+        );
>     }
> 
>     return $logs;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 36118: 162277 | 162278 | 162279 | 162585 | 162586 | 162587 | 163178 | 163179 | 163180 | 163181 | 163283 | 163284 | 163285 | 163286 | 164181 | 164182 | 164183 | 164184 | 164185 | 164398 | 164399 | 164400 | 164401 | 164402 | 164405 | 164406 | 164407 | 164408 | 164409 | 170450 | 170451 | 170452 | 170453 | 170454 | 171372 | 171373 | 171374 | 171375 | 172785 | 172786 | 172787 | 172788 | 172789 | 173023 | 173024 | 173025 | 173026 | 173027 | 173028 | 173029 | 173030 | 173031 | 173032 | 173033 | 173034 | 173035 | 173036 | 173037 | 173038 | 173039 | 173040 | 173041