Attachment 163258 Details for Bug 36334 – Bug 36334: Remove unnecessary JS code from member.tt

[patch] Bug 36334: Remove unnecessary JS code from member.tt

Bug-36334-Remove-unnecessary-JS-code-from-membertt.patch (text/plain), 2.08 KB, created by Pedro Amorim on 2024-03-15 16:39:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-03-15 16:39:02 UTC

Size: 2.08 KB

patch

obsolete

>From 80104b2d848501a863bd33c55249ab1571b55bf1 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 15 Mar 2024 15:38:18 +0100
>Subject: [PATCH] Bug 36334: Remove unnecessary JS code from member.tt
>
>This was initially written to set the input/select in the form in the
>left side of the main patron search page.
>
>But this is now done in patron-search.inc:
>koha-tmpl/intranet-tmpl/prog/en/includes/patron-search.inc:
>  <input type="text" class="search_patron_filter" value="[% search_filter | html %]" class="focus" />
>
>I don't see how/when this code is still used.
>
>Additionally:
> #searchmember_filter
> => does not exist, it's .search_patron_filter
>
> $("searchfieldstype_filter").val("[% searchfieldstype | html %]");
> => Not a valid selector
>
>Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>---
> .../prog/en/modules/members/member.tt            | 16 ----------------
> 1 file changed, 16 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>index e7021a21e35..31f849ee78f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt
>@@ -291,22 +291,6 @@
>                     }
>                 });
>             });
>-
>-            [% IF searchmember %]
>-                $("#searchmember_filter").val("[% searchmember | html %]");
>-            [% END %]
>-            [% IF searchfieldstype %]
>-                $("searchfieldstype_filter").val("[% searchfieldstype | html %]");
>-            [% END %]
>-            [% IF searchtype %]
>-                $("#searchtype_filter option[value='[% searchtype | html %]']").prop("selected", true);
>-            [% END %]
>-            [% IF categorycode_filter %]
>-                $("#categorycode_filter").val("[% categorycode_filter | html %]");
>-            [% END %]
>-            [% IF branchcode_filter %]
>-                $("#branchcode_filter").val("[% branchcode_filter | html %]");
>-            [% END %]
>         });
> 
>         function patronListAdd(){
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 36334: 163249 | 163258 | 163268 | 163269 | 163275