Bugzilla – Attachment 163309 Details for
Bug 36341
"Hold starts on date" should be limited to future dates
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36341: Add futureinclusive to future holds
Bug-36341-Add-futureinclusive-to-future-holds.patch (text/plain), 3.63 KB, created by
Martin Renvoize (ashimema)
on 2024-03-18 11:40:00 UTC
(
hide
)
Description:
Bug 36341: Add futureinclusive to future holds
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-03-18 11:40:00 UTC
Size:
3.63 KB
patch
obsolete
>From 44249ca1bf502b7b4c35ee8b22c792e1423a6c77 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Mon, 18 Mar 2024 11:35:13 +0000 >Subject: [PATCH] Bug 36341: Add futureinclusive to future holds > >This patch adds the flatpickr-futureinclusive data to the input field >for "Hold starts on date" in the OPAC. > >We also add 'flatpickr-future' data to the input field for expiration >date as it also doesn't make sense to allow this to be a past data >either. > >Test plan >1) Attempt to place a hold on an item from the OPAC >2) Expand the 'Show more options' dropdown >3) Note that without the patch 'Hold not needed after' allows setting to > a date in the past. >4) Enable `AllowHoldDateInFuture` and `OPACAllowHoldDateInFuture` system > preferences >5) The 'Hold starts on date' option should now appear if you refresh > your hold placing page in the OPAC. >6) Note that the above input also allows setting a past date >7) Apply patch >8) Neith input should allow past dates now. >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >index 58f1397012c..e2a3da84882 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-reserve.tt >@@ -288,7 +288,7 @@ > [% IF ( reserve_in_future ) %] > <li> > <label for="from[% bibitemloo.biblionumber | html %]">Hold starts on date:</label> >- <input type="text" name="reserve_date_[% bibitemloo.biblionumber | html %]" id="from[% bibitemloo.biblionumber | html %]" data-start_for="to[% bibitemloo.biblionumber | html %]" size="10" class="flatpickr holddatefrom" /> >+ <input type="text" name="reserve_date_[% bibitemloo.biblionumber | html %]" id="from[% bibitemloo.biblionumber | html %]" data-start_for="to[% bibitemloo.biblionumber | html %]" data-flatpickr-futureinclusive="true" size="10" class="flatpickr holddatefrom" /> > <span class="date-format from" data-biblionumber="[% bibitemloo.biblionumber | html %]">[% INCLUDE 'date-format.inc' %]</span> > <div class="required_label" style="display:none;">Required</div> > </li> >@@ -296,7 +296,7 @@ > > <li> > <label for="to[% bibitemloo.biblionumber | html %]">Hold not needed after:</label> >- <input type="text" name="expiration_date_[% bibitemloo.biblionumber | html %]" id="to[% bibitemloo.biblionumber | html %]" size="10" class="flatpickr futuredate" /> >+ <input type="text" name="expiration_date_[% bibitemloo.biblionumber | html %]" id="to[% bibitemloo.biblionumber | html %]" size="10" data-flatpickr-future="true" class="flatpickr futuredate" /> > <span class="date-format to" data-biblionumber="[% bibitemloo.biblionumber | html %]">[% INCLUDE 'date-format.inc' %]</span> > <div class="required_label" style="display:none;">Required</div> > </li> >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36341
:
163309
|
164218
|
164219
|
165721