Bugzilla – Attachment 163379 Details for
Bug 36356
FrameworkPlugin.t does not rollback properly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36356: Fix rollback from FrameworkPlugin.t
Bug-36356-Fix-rollback-from-FrameworkPlugint.patch (text/plain), 1.40 KB, created by
Jonathan Druart
on 2024-03-19 08:20:53 UTC
(
hide
)
Description:
Bug 36356: Fix rollback from FrameworkPlugin.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-03-19 08:20:53 UTC
Size:
1.40 KB
patch
obsolete
>From 2cc298b4092b0a8fd3dd062d348c47377fb8539a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 19 Mar 2024 09:16:52 +0100 >Subject: [PATCH] Bug 36356: Fix rollback from FrameworkPlugin.t > >rollback ineffective with AutoCommit enabled at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1651. > >I have not investigated more than that. Reaching this was already the >end of a long road... (see comment 0) > >Test plan: >0. Do not apply this patch >1. select count(*) from branches >Note the value >2. Run > prove t/db_dependent/FrameworkPlugin.t >=> There is a warning >3. Repeat 1. >=> There are too many libraries! >4. Apply the patch, retry 1, 2, 3 >=> No warning, no library added by the tests >--- > t/db_dependent/FrameworkPlugin.t | 3 +++ > 1 file changed, 3 insertions(+) > >diff --git a/t/db_dependent/FrameworkPlugin.t b/t/db_dependent/FrameworkPlugin.t >index 41baf49153b..71a8e3a1f3e 100755 >--- a/t/db_dependent/FrameworkPlugin.t >+++ b/t/db_dependent/FrameworkPlugin.t >@@ -18,6 +18,9 @@ use Koha::Util::FrameworkPlugin qw( biblio_008 ); > our @includes; > GetOptions( 'include=s{,}' => \@includes ); #not used by default ! > >+# Because of CGI::Session being buggy (see bug 17427) and a use of get_session somewhere here >+t::lib::Mocks::mock_preference( 'SessionStorage', 'tmp' ); >+ > my $schema = Koha::Database->new->schema; > $schema->storage->txn_begin; > our $dbh = C4::Context->dbh; >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36356
: 163379