Attachment 163398 Details for Bug 35919 – Bug 35919: Add Koha::Biblio::Metadata->source_allows_editing

[patch] Bug 35919: Add Koha::Biblio::Metadata->source_allows_editing

Bug-35919-Add-KohaBiblioMetadata-sourceallowsediti.patch (text/plain), 2.80 KB, created by Jonathan Druart on 2024-03-19 11:28:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-03-19 11:28:40 UTC

Size: 2.80 KB

patch

obsolete

>From 9b960b5a53b9787c7ae1d68815612c7a83eeeadc Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Thu, 25 Jan 2024 12:29:37 -0300
>Subject: [PATCH] Bug 35919: Add Koha::Biblio::Metadata->source_allows_editing
>
>This patch adds a convenient method that tells if the record is
>editable, according to it's record source.
>
>To test:
>1. Apply this patch
>2. Run:
>   $ ktd
>  k$ prove t/db_dependent/Koha/Biblio/Metadata.t
>=> SUCCESS: Tests pass! Use cases covered!
>3. Sign off :-D
>
>Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
>
>Bug 31791: Rename can_be_edited -> source_allows_editing
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> Koha/Biblio/Metadata.pm               | 17 +++++++++++++++++
> t/db_dependent/Koha/Biblio/Metadata.t | 27 ++++++++++++++++++++++++++-
> 2 files changed, 43 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/Biblio/Metadata.pm b/Koha/Biblio/Metadata.pm
>index d5bfea5cd00..926beda2c56 100644
>--- a/Koha/Biblio/Metadata.pm
>+++ b/Koha/Biblio/Metadata.pm
>@@ -170,6 +170,23 @@ sub record_strip_nonxml {
>     return $self->record( { %$params, record => $record } );
> }
> 
>+=head3 source_allows_editing
>+
>+    if ( $metadata->source_allows_editing ) { ... }
>+
>+Returns a boolean denoting whether the metadata's record source allows
>+it to be edited.
>+
>+=cut
>+
>+sub source_allows_editing {
>+    my ($self) = @_;
>+
>+    my $rs = $self->_result->record_source;
>+    return 1 unless $rs;
>+    return $rs->can_be_edited;
>+}
>+
> =head2 Internal methods
> 
> =head3 _embed_items
>diff --git a/t/db_dependent/Koha/Biblio/Metadata.t b/t/db_dependent/Koha/Biblio/Metadata.t
>index 5318ebc23f8..7a459938615 100755
>--- a/t/db_dependent/Koha/Biblio/Metadata.t
>+++ b/t/db_dependent/Koha/Biblio/Metadata.t
>@@ -17,7 +17,7 @@
> 
> use Modern::Perl;
> 
>-use Test::More tests => 4;
>+use Test::More tests => 5;
> use Test::Exception;
> use Test::Warn;
> 
>@@ -266,3 +266,28 @@ subtest '_embed_items' => sub {
> 
>     $schema->storage->txn_rollback;
> };
>+
>+subtest 'source_allows_editing() tests' => sub {
>+
>+    plan tests => 4;
>+
>+    $schema->storage->txn_begin;
>+
>+    my $biblio = $builder->build_sample_biblio;
>+
>+    my $metadata = $biblio->metadata;
>+    is( $metadata->record_source_id, undef, 'No record source defined for metatada object' );
>+    ok( $metadata->source_allows_editing, 'No record source, can be edited' );
>+
>+    my $source = $builder->build_object( { class => 'Koha::RecordSources', value => { can_be_edited => 1 } } );
>+    $metadata->record_source_id( $source->id )->store();
>+
>+    ok( $metadata->source_allows_editing, 'Record source allows, can be edited' );
>+
>+    $source->can_be_edited(0)->store();
>+    $metadata->discard_changes;
>+
>+    ok( !$metadata->source_allows_editing, 'Record source does not allow, cannot be edited' );
>+
>+    $schema->storage->txn_rollback;
>+};
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 35919: 161531 | 161532 | 161533 | 161534 | 161535 | 161537 | 161538 | 161577 | 161578 | 161579 | 161580 | 161581 | 161582 | 161583 | 162489 | 162594 | 162595 | 162596 | 162599 | 163348 | 163349 | 163350 | 163351 | 163352 | 163353 | 163354 | 163355 | 163360 | 163369 | 163389 | 163390 | 163391 | 163392 | 163393 | 163394 | 163395 | 163396 | 163397 | 163398 | 163399 | 163400 | 164708 | 164709 | 164710 | 164711 | 164712 | 164713 | 164714 | 164715 | 164716 | 164717 | 165274