Attachment 163400 Details for Bug 35919 – Bug 35919: Fix cypress tests

[patch] Bug 35919: Fix cypress tests

Bug-35919-Fix-cypress-tests.patch (text/plain), 3.08 KB, created by Jonathan Druart on 2024-03-19 11:28:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-03-19 11:28:46 UTC

Size: 3.08 KB

patch

obsolete

>From a9199133e0aa3d78ee3933ff6e5fb98c185f0f80 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 19 Mar 2024 12:24:21 +0100
>Subject: [PATCH] Bug 35919: Fix cypress tests
>
>And remove "remove", "delete" inconsistency
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../prog/js/vue/components/Admin/RecordSources/List.vue   | 8 ++++----
> t/cypress/integration/Admin/RecordSources_spec.ts         | 8 ++++----
> 2 files changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/RecordSources/List.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/RecordSources/List.vue
>index f8776f9b35d..a1595b9e64f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/RecordSources/List.vue
>+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/Admin/RecordSources/List.vue
>@@ -105,7 +105,7 @@ export default {
>             this.setConfirmationDialog(
>                 {
>                     title: this.$__(
>-                        "Are you sure you want to remove this record source?"
>+                        "Are you sure you want to delete this record source?"
>                     ),
>                     message: record_source.name,
>                     accept_label: this.$__("Yes, delete"),
>@@ -118,9 +118,9 @@ export default {
>                         .then(
>                             success => {
>                                 this.setMessage(
>-                                    this.$__("Record source %s deleted").format(
>-                                        record_source.name
>-                                    ),
>+                                    this.$__(
>+                                        "Record source '%s' deleted"
>+                                    ).format(record_source.name),
>                                     true
>                                 )
>                                 dt.draw()
>diff --git a/t/cypress/integration/Admin/RecordSources_spec.ts b/t/cypress/integration/Admin/RecordSources_spec.ts
>index 0fa77a47b18..e22dc5612e6 100644
>--- a/t/cypress/integration/Admin/RecordSources_spec.ts
>+++ b/t/cypress/integration/Admin/RecordSources_spec.ts
>@@ -162,18 +162,18 @@ describe("Record sources CRUD tests", () => {
>             .contains("Delete")
>             .click();
>         cy.get(".dialog.alert.confirmation h1").contains(
>-            "Are you sure you want to remove this record source?"
>+            "Are you sure you want to delete this record source?"
>         );
>         cy.contains("Source 2");
>-        cy.contains("No, do not remove").click();
>+        cy.contains("No, do not delete").click();
> 
>         cy.get("#record_sources_list table tbody tr:nth-child(2n+2)")
>             .contains("Delete")
>             .click();
>         cy.contains("Source 2");
>-        cy.contains("Yes, remove").click();
>+        cy.contains("Yes, delete").click();
>         cy.get("main div[class='dialog message']").contains(
>-            "Record source 'Source 2' removed"
>+            "Record source 'Source 2' deleted"
>         );
>     });
> });
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 35919: 161531 | 161532 | 161533 | 161534 | 161535 | 161537 | 161538 | 161577 | 161578 | 161579 | 161580 | 161581 | 161582 | 161583 | 162489 | 162594 | 162595 | 162596 | 162599 | 163348 | 163349 | 163350 | 163351 | 163352 | 163353 | 163354 | 163355 | 163360 | 163369 | 163389 | 163390 | 163391 | 163392 | 163393 | 163394 | 163395 | 163396 | 163397 | 163398 | 163399 | 163400 | 164708 | 164709 | 164710 | 164711 | 164712 | 164713 | 164714 | 164715 | 164716 | 164717 | 165274