Bugzilla – Attachment 163422 Details for
Bug 24879
Add missing authentication checks
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24879: Exclude koha_perl_deps.pl
Bug-24879-Exclude-kohaperldepspl.patch (text/plain), 1.96 KB, created by
Martin Renvoize
on 2024-03-19 11:49:49 UTC
(
hide
)
Description:
Bug 24879: Exclude koha_perl_deps.pl
Filename:
MIME Type:
Creator:
Martin Renvoize
Created:
2024-03-19 11:49:49 UTC
Size:
1.96 KB
patch
obsolete
>From 0e788336a9697515a04fc5302c1d34c76025ae73 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 15 Mar 2024 10:19:16 +0100 >Subject: [PATCH] Bug 24879: Exclude koha_perl_deps.pl > >And tidy. > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > xt/find-missing-auth_checks.t | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > >diff --git a/xt/find-missing-auth_checks.t b/xt/find-missing-auth_checks.t >index d86fab2917b..a1a5c0d594d 100755 >--- a/xt/find-missing-auth_checks.t >+++ b/xt/find-missing-auth_checks.t >@@ -20,18 +20,19 @@ use Test::More; > > use File::Slurp qw(read_file); > >-my @excluded_paths = qw(C4 debian docs etc installer/data install_misc Koha misc selenium t test tmp xt changelanguage.pl build-resources.PL fix-perl-path.PL ); >-push @excluded_paths, 'opac'; # We cannot test the OPAC scripts, some can be accessed without authentication >+my @excluded_paths = >+ qw(C4 debian docs etc installer/data install_misc Koha misc selenium t test tmp xt changelanguage.pl build-resources.PL fix-perl-path.PL koha_perl_deps.pl ); >+push @excluded_paths, 'opac'; # We cannot test the OPAC scripts, some can be accessed without authentication > >-my $grep_cmd = q{git grep -l '#!/usr/bin/perl' -- } . join( ' ', map { qq{':!$_'} } @excluded_paths ); >-my @files = `$grep_cmd`; >+my $grep_cmd = q{git grep -l '#!/usr/bin/perl' -- } . join( ' ', map { qq{':!$_'} } @excluded_paths ); >+my @files = `$grep_cmd`; > > my @missing_auth_check; > FILE: foreach my $file (@files) { > chomp $file; > my @lines = read_file($file); >- for my $line ( @lines ) { >- for my $routine ( qw( get_template_and_user check_cookie_auth checkauth check_api_auth C4::Service->init ) ) { >+ for my $line (@lines) { >+ for my $routine (qw( get_template_and_user check_cookie_auth checkauth check_api_auth C4::Service->init )) { > next FILE if $line =~ m|^[^#]*$routine|; > } > } >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24879
:
100885
|
106978
|
163139
|
163140
|
163141
|
163142
|
163143
|
163183
|
163417
|
163418
|
163419
|
163420
|
163421
| 163422 |
163977