Attachment 163507 Details for Bug 36367 – Bug 36367: Remove obsolete tests

[patch] Bug 36367: Remove obsolete tests

Bug-36367-Remove-obsolete-tests.patch (text/plain), 1.93 KB, created by Jonathan Druart on 2024-03-20 07:54:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-03-20 07:54:27 UTC

Size: 1.93 KB

patch

obsolete

>From 97b8f69466f986f2eb93ed512afef3343490033e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 20 Mar 2024 08:51:45 +0100
>Subject: [PATCH] Bug 36367: Remove obsolete tests
>
>---
> t/db_dependent/Auth.t | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/t/db_dependent/Auth.t b/t/db_dependent/Auth.t
>index 2e7aa7c0044..917082d47c4 100755
>--- a/t/db_dependent/Auth.t
>+++ b/t/db_dependent/Auth.t
>@@ -761,7 +761,7 @@ subtest 'check_cookie_auth' => sub {
> };
> 
> subtest 'checkauth & check_cookie_auth' => sub {
>-    plan tests => 34;
>+    plan tests => 33;
> 
>     # flags = 4 => { catalogue => 1 }
>     my $patron = $builder->build_object({ class => 'Koha::Patrons', value => { flags => 4 } });
>@@ -907,14 +907,13 @@ subtest 'checkauth & check_cookie_auth' => sub {
>         is( $auth_status, "ok" );
>         is( $session->id, $sessionID, 'Same session' );
>         # Two additional tests on userenv
>-        is( $C4::Context::context->{activeuser}, $session->id, 'Check if environment has been setup for session' );
>         is( C4::Context->userenv->{id}, $userid, 'Check userid in userenv' );
>     }
> };
> 
> subtest 'Userenv clearing in check_cookie_auth' => sub {
>     # Note: We did already test userenv for a logged-in user in previous subtest
>-    plan tests => 9;
>+    plan tests => 8;
> 
>     t::lib::Mocks::mock_preference( 'timeout', 600 );
>     my $cgi = CGI->new;
>@@ -924,7 +923,6 @@ subtest 'Userenv clearing in check_cookie_auth' => sub {
>     my ($userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth($cgi, 1);
>     my ( $auth_status, $session) = C4::Auth::check_cookie_auth( $sessionID );
>     is( $auth_status, 'anon', 'Should be anonymous' );
>-    is( $C4::Context::context->{activeuser}, $session->id, 'Check activeuser' );
>     is( defined C4::Context->userenv, 1, 'There should be a userenv' );
>     is(  C4::Context->userenv->{id}, q{}, 'userid should be empty string' );
> 
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 36367: 163500 | 163501 | 163502 | 163503 | 163504 | 163505 | 163506 | 163507 | 163508 | 165115 | 165116 | 165117 | 165118 | 165119 | 165120 | 165121 | 165122 | 165123 | 165124 | 165125 | 165126 | 167380 | 167381 | 167382 | 167383 | 167384 | 167385 | 167386 | 167387 | 167388 | 167389 | 167390 | 167391