Bugzilla – Attachment 163519 Details for
Bug 36355
Auth/csrf.ts is failing if library with long info in the DB
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36355: Prevent csrf.ts to fail if DB has libraries with long name
Bug-36355-Prevent-csrfts-to-fail-if-DB-has-librari.patch (text/plain), 1.95 KB, created by
Martin Renvoize (ashimema)
on 2024-03-20 10:24:52 UTC
(
hide
)
Description:
Bug 36355: Prevent csrf.ts to fail if DB has libraries with long name
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-03-20 10:24:52 UTC
Size:
1.95 KB
patch
obsolete
>From 1a563b661144d7e92d6252ed039125e1e14049bc Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 19 Mar 2024 09:29:13 +0100 >Subject: [PATCH] Bug 36355: Prevent csrf.ts to fail if DB has libraries with > long name > >If one library has a long name the "Delete" button will not appear on >the screen and the cypress test will fail > Timed out retrying after 10050ms: `cy.click()` failed because the center of this element is hidden from view > >We can either increase the size of the screen or force the click even if >the button is not visible. > >Test plan: >Edit a library and set info with long name, address, etc. >Run the cypress test: > yarn cypress run --spec t/cypress/integration/Auth/csrf.ts >Note the failure, you can watch the video and notice that the delete >button is not on the screen (t/cypress/videos/csrf.ts.mp4) >Apply the patch, try again >=> Succes > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/cypress/integration/Auth/csrf.ts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/t/cypress/integration/Auth/csrf.ts b/t/cypress/integration/Auth/csrf.ts >index 704218d3a6f..a8ec6c6f581 100644 >--- a/t/cypress/integration/Auth/csrf.ts >+++ b/t/cypress/integration/Auth/csrf.ts >@@ -128,7 +128,7 @@ describe("CSRF", () => { > > cy.visit("/cgi-bin/koha/admin/branches.pl"); > cy.get("select[name='libraries_length']").select("-1"); >- cy.get("#delete_library_" + branchcode).click(); >+ cy.get("#delete_library_" + branchcode).click({ force: true }); > > // Remove CSRF Token > cy.get("form[method='post']") >@@ -157,7 +157,7 @@ describe("CSRF", () => { > > cy.visit("/cgi-bin/koha/admin/branches.pl"); > cy.get("select[name='libraries_length']").select("-1"); >- cy.get("#delete_library_" + branchcode).click(); >+ cy.get("#delete_library_" + branchcode).click({ force: true }); > > cy.contains("Yes, delete").click(); > >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36355
:
163382
| 163519