Bugzilla – Attachment 163556 Details for
Bug 36374
Some of our JS files should stay tidy
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36374: Move modal js under /modals
Bug-36374-Move-modal-js-under-modals.patch (text/plain), 6.05 KB, created by
Martin Renvoize (ashimema)
on 2024-03-20 15:32:30 UTC
(
hide
)
Description:
Bug 36374: Move modal js under /modals
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-03-20 15:32:30 UTC
Size:
6.05 KB
patch
obsolete
>From ab563ee7db0ed06a2b43358be67c97e703d0065a Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 20 Mar 2024 15:28:10 +0000 >Subject: [PATCH] Bug 36374: Move modal js under /modals > >I also didn't stick to the more recent switch to putting modal js under >a /modals dirctory. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 2 +- > .../intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt | 2 +- > .../prog/en/modules/catalogue/labeledMARCdetail.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt | 2 +- > .../intranet-tmpl/prog/js/{ => modals}/place_booking_modal.js | 0 > 8 files changed, 7 insertions(+), 7 deletions(-) > rename koha-tmpl/intranet-tmpl/prog/js/{ => modals}/place_booking_modal.js (100%) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >index 83518866900..8ca28f4e83e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/bookings/list.tt >@@ -66,7 +66,7 @@ > [% INCLUDE 'select2.inc' %] > [% INCLUDE 'js-patron-format.inc' %] > [% INCLUDE 'js-date-format.inc' %] >- [% Asset.js("js/place_booking_modal.js") | $raw %] >+ [% Asset.js("js/modals/place_booking_modal.js") | $raw %] > [% Asset.js("js/cancel_booking_modal.js") | $raw %] > <script> > var cancel_success = 0; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt >index 28d960abefb..c3cf486b7d5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/ISBDdetail.tt >@@ -89,7 +89,7 @@ > [% INCLUDE 'calendar.inc' %] > [% INCLUDE 'select2.inc' %] > [% Asset.js("js/catalog.js") | $raw %] >- [% Asset.js("js/place_booking_modal.js") | $raw %] >+ [% Asset.js("js/modals/place_booking_modal.js") | $raw %] > [% Asset.js("js/browser.js") | $raw %] > [% IF ( Koha.Preference('CatalogConcerns') ) %] > <script> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt >index ef6588157df..a46fe67026e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/MARCdetail.tt >@@ -215,7 +215,7 @@ > [% INCLUDE 'calendar.inc' %] > [% INCLUDE 'select2.inc' %] > [% Asset.js("js/catalog.js") | $raw %] >- [% Asset.js("js/place_booking_modal.js") | $raw %] >+ [% Asset.js("js/modals/place_booking_modal.js") | $raw %] > [% Asset.js("js/browser.js") | $raw %] > [% IF ( Koha.Preference('CatalogConcerns') ) %] > <script> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 993f67fdcb8..99a656c5915 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -1822,7 +1822,7 @@ > [% INCLUDE 'js-biblio-format.inc' %] > [% Asset.js("js/browser.js") | $raw %] > [% Asset.js("js/table_filters.js") | $raw %] >- [% Asset.js("js/place_booking_modal.js") | $raw %] >+ [% Asset.js("js/modals/place_booking_modal.js") | $raw %] > <script> > var browser; > browser = KOHA.browser('[% searchid | html %]', parseInt(biblionumber, 10)); >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt >index 2a32fa8768d..3f897d7f902 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/imageviewer.tt >@@ -142,7 +142,7 @@ > [% INCLUDE 'calendar.inc' %] > [% INCLUDE 'select2.inc' %] > [% Asset.js("js/catalog.js") | $raw %] >- [% Asset.js("js/place_booking_modal.js") | $raw %] >+ [% Asset.js("js/modals/place_booking_modal.js") | $raw %] > [% IF ( Koha.Preference('CatalogConcerns') ) %] > <script> > /* Set a variable needed by add_catalog_concern.js */ >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt >index dfa22246e63..de6c365ad49 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/labeledMARCdetail.tt >@@ -104,7 +104,7 @@ > [% INCLUDE 'calendar.inc' %] > [% INCLUDE 'select2.inc' %] > [% Asset.js("js/catalog.js") | $raw %] >- [% Asset.js("js/place_booking_modal.js") | $raw %] >+ [% Asset.js("js/modals/place_booking_modal.js") | $raw %] > [% Asset.js("js/browser.js") | $raw %] > [% IF ( Koha.Preference('CatalogConcerns') ) %] > <script> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >index a00db538ac0..1e5acb6d49b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt >@@ -523,7 +523,7 @@ > [% INCLUDE 'calendar.inc' %] > [% INCLUDE 'select2.inc' %] > [% Asset.js("js/catalog.js") | $raw %] >- [% Asset.js("js/place_booking_modal.js") | $raw %] >+ [% Asset.js("js/modals/place_booking_modal.js") | $raw %] > [% Asset.js("js/browser.js") | $raw %] > [% Asset.js("js/checkout_renewals_modal.js") | $raw %] > [% IF ( Koha.Preference('CatalogConcerns') ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/js/place_booking_modal.js b/koha-tmpl/intranet-tmpl/prog/js/modals/place_booking_modal.js >similarity index 100% >rename from koha-tmpl/intranet-tmpl/prog/js/place_booking_modal.js >rename to koha-tmpl/intranet-tmpl/prog/js/modals/place_booking_modal.js >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36374
:
163555
|
163556
|
163558
|
163559
|
163560
|
163587
|
163588
|
163589
|
163591
|
163592
|
163593
|
163594
|
163595
|
163596
|
165732
|
165733
|
165734
|
165735
|
165736
|
165737
|
165738
|
165739
|
165740
|
165741
|
165742
|
165743