Attachment 163576 Details for Bug 36378 – Bug 36378: Cannot stay logged in if AutoLocation is enabled but branch ip is not set correctly

[patch] Bug 36378: Cannot stay logged in if AutoLocation is enabled but branch ip is not set correctly

Bug-36378-Cannot-stay-logged-in-if-AutoLocation-is.patch (text/plain), 1.34 KB, created by Kyle M Hall (khall) on 2024-03-20 19:34:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2024-03-20 19:34:54 UTC

Size: 1.34 KB

patch

obsolete

>From f6c6cdc3c1a9a1eccebb8ef23f37df8979d6b852 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 20 Mar 2024 15:32:50 -0400
>Subject: [PATCH] Bug 36378: Cannot stay logged in if AutoLocation is enabled
> but branch ip is not set correctly
>
>We can get into a scenario what a user cannot stay logged in for more than a single page load.
>If AutoLocation is enabled with branch IP addresses being set to a space, you will be logged out with every page load.
>
>Test Plan:
>1) Set your branch ip to a space
>2) Enable AutoLocation
>3) Restart all the things!
>4) Log out
>5) Log in
>6) Browse to another page
>7) You are logged out
>8) Apply patch
>9) Repeat 1-6
>10) You are not logged out!
>---
> C4/Auth.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/C4/Auth.pm b/C4/Auth.pm
>index a8c21740f00..67533aa1be3 100644
>--- a/C4/Auth.pm
>+++ b/C4/Auth.pm
>@@ -1212,6 +1212,7 @@ sub checkauth {
>                         # we have to check they are coming from the right ip range
>                         my $domain = $branches->{$branchcode}->{'branchip'};
>                         $domain =~ s|\.\*||g;
>+                        $domain =~ s/\s+//g;
>                         if ( $ip !~ /^$domain/ ) {
>                             $cookie = $cookie_mgr->replace_in_list( $cookie, $query->cookie(
>                                 -name     => 'CGISESSID',
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 36378: 163576 | 163716 | 166625