Bugzilla – Attachment 163639 Details for
Bug 35149
Add "do nothing" option to CircAutoPrintQuickSlip system preference
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35149: Add Option to ignore submit of checkout field when empty
Bug-35149-Add-Option-to-ignore-submit-of-checkout-.patch (text/plain), 2.22 KB, created by
Laura Escamilla
on 2024-03-21 15:57:22 UTC
(
hide
)
Description:
Bug 35149: Add Option to ignore submit of checkout field when empty
Filename:
MIME Type:
Creator:
Laura Escamilla
Created:
2024-03-21 15:57:22 UTC
Size:
2.22 KB
patch
obsolete
>From 6c607e8ee802d1c423e7ee67f4bf8d57a4f501c4 Mon Sep 17 00:00:00 2001 >From: Stefan Berndtsson <stefan.berndtsson@gmail.com> >Date: Mon, 25 Sep 2023 14:05:06 +0200 >Subject: [PATCH] Bug 35149: Add Option to ignore submit of checkout field when > empty > >1) Apply patch >2) Set CircAutoPrintQuickSlip to "do nothing" >3) Go to the checkouts form for a specific patron >4) Submit the form with empty value >5) Verify that no action is taken and you stay on the current page > >Signed-off-by: Laura Escamilla <laura.escamilla@bywatersolutions.com> >--- > .../prog/en/modules/admin/preferences/circulation.pref | 1 + > koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt | 2 ++ > 2 files changed, 3 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >index b9169b203f..3f6a6372b7 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref >@@ -127,6 +127,7 @@ Circulation: > - pref: CircAutoPrintQuickSlip > choices: > clear: "clear the screen" >+ ignore: "do nothing" > qslip: "open a print quick slip window" > slip: "open a print slip window" > - . >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >index 308d8cc60d..9da2c54faf 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt >@@ -1090,6 +1090,8 @@ > [% IF ( CircAutoPrintQuickSlip == 'clear' ) %] > window.location='/cgi-bin/koha/circ/circulation.pl'; > return false; >+ [% ELSIF ( CircAutoPrintQuickSlip == 'ignore' ) %] >+ return false; > [% ELSE %] > window.open("/cgi-bin/koha/members/printslip.pl?borrowernumber=" + borrowernumber + "&print=issue[% CircAutoPrintQuickSlip | html %]", "printwindow"); > return false; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35149
:
157800
|
162323
| 163639 |
163640
|
166582