Attachment 163693 Details for Bug 35857 – Bug 35857: Update authority search pop-up windows with consistent footer markup

[patch] Bug 35857: Update authority search pop-up windows with consistent footer markup

Bug-35857-Update-authority-search-pop-up-windows-w.patch (text/plain), 4.33 KB, created by Kyle M Hall (khall) on 2024-03-22 10:50:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2024-03-22 10:50:00 UTC

Size: 4.33 KB

patch

obsolete

>From 651dbec6f3b092107e9f012ab29b757ef3a5ab98 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 26 Jan 2024 18:35:50 +0000
>Subject: [PATCH] Bug 35857: Update authority search pop-up windows with
> consistent footer markup
>
>This patch updates the cataloging authority finder template in order to
>style submission and close buttons in a fixed footer at the bottom of
>the pop-up window, with markup consistent with other pop-up windows.
>
>Some inline CSS has been removed in favor of styling the "Clear" button
>like a default button. Unrelated, "No results found" message has been
>wrapped in a "dialog message" div for consistency's sake.
>
>To test, apply the patch and go to Cataloging -> New record.
>
>- In the "Add MARC record" form, locate a tag which is linked to an
>  authority type, e.g. 100$a.
>- Click the icon to the right of the field to trigger the authority
>  search window.
>- There should be a fixed footer in the pop-up window with buttons for
>  "Submit," "Clear form," and "Close window." Test that each behave
>  correctly.
>  - The search results view should have the same footer.
>  - Clicking "Choose" from the search results should close the window
>    and populate the MARC tag with the correct authority data.
>
>Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> .../prog/en/includes/auth-finder-search.inc       | 12 ++++++++++--
> .../prog/en/modules/authorities/auth_finder.tt    | 11 -----------
> .../modules/authorities/searchresultlist-auth.tt  | 15 +++++----------
> 3 files changed, 15 insertions(+), 23 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc
>index 28775c99772..5b5a8828e89 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/auth-finder-search.inc
>@@ -179,6 +179,14 @@
>             </ol>
>         </fieldset>
>         [% END %]
>-        <fieldset class="action"> <input type="submit" value="Search" class="submit" id="search" /> <input type="reset" id="clear-form" value="Clear form"> <a id="cancel" class="cancel close" href="#">Cancel</a>
>-        </fieldset>
>+
>+        <nav class="navbar navbar-default navbar-fixed-bottom">
>+            <div class="container-fluid">
>+                <fieldset class="action">
>+                    <input type="submit" class="btn btn-primary" id="search" value="Search" />
>+                    <input type="reset" id="clear-form" class="btn btn-default" value="Clear form" />
>+                    <button type="button" class="btn btn-default close_window">Close window</button>
>+                </fieldset>
>+            </div>
>+        </nav>
> </form>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/auth_finder.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/auth_finder.tt
>index 69dafe73dec..1c6f801f2c4 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/auth_finder.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/auth_finder.tt
>@@ -8,17 +8,6 @@
>     [% t("Koha") | html %]
> [% END %]</title>
> [% INCLUDE 'doc-head-close.inc' %]
>-<style>
>-#clear-form {
>-    border:0;
>-    background:none;
>-    color:#004d99;
>-    padding-left:1em;
>-}
>-#clear-form:hover {
>-    color:#538200;
>-}
>-</style>
> </head>
> 
> <body id="auth_auth_finder" class="auth">
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt
>index c063817a0f0..ee21847f277 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist-auth.tt
>@@ -19,15 +19,6 @@
> .usefor li {
>     list-style-type: none;
> }
>-#clear-form {
>-    border:0;
>-    background:none;
>-    color:#004d99;
>-    padding-left:1em;
>-}
>-#clear-form:hover {
>-    color:#538200;
>-}
> </style>
> </head>
> 
>@@ -60,7 +51,11 @@
>                 [% ELSE %]
>                     
>                 
>-            </div><p>No results found</p>[% END %]
>+            </div>
>+            <div class="dialog message">
>+                <p>No results found</p>
>+            </div>
>+            [% END %]
>         </div>
>         [% IF ( result ) %]<div id="resultlist">
>             <table>
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 35857: 161560 | 161562 | 163693