Attachment 163726 Details for Bug 36395 – Bug 36395: Remove useless fetch in admin/marc_subfields_structure.pl

[patch] Bug 36395: Remove useless fetch in admin/marc_subfields_structure.pl

Bug-36395-Remove-useless-fetch-in-adminmarcsubfiel.patch (text/plain), 1.19 KB, created by Owen Leonard on 2024-03-22 17:31:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2024-03-22 17:31:54 UTC

Size: 1.19 KB

patch

obsolete

>From dfbde1838f7bb503e83aee1b8bdf21d31af68df7 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 21 Mar 2024 15:52:52 +0100
>Subject: [PATCH] Bug 36395: Remove useless fetch in
> admin/marc_subfields_structure.pl
>
>Since (a long time ago!)
>  commit 62aa3f4292d83bc9304e296de5f0830e28510492
>  Bug 17216: Use Koha::AVC from mss.pl
>
>This $sth2 is never fetched, we are retrieving the AV cat using
>Koha::AV::Categories
>
>Sponsored-by: The Research University in the Helmholtz Association (KIT)
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>---
> admin/marc_subfields_structure.pl | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/admin/marc_subfields_structure.pl b/admin/marc_subfields_structure.pl
>index 260e3ad900..70801fefa7 100755
>--- a/admin/marc_subfields_structure.pl
>+++ b/admin/marc_subfields_structure.pl
>@@ -101,8 +101,6 @@ if ( $op eq 'add_form' ) {
> 
>     # build authorised value list
>     $sth2->finish;
>-    $sth2 = $dbh->prepare("select distinct category from authorised_values");
>-    $sth2->execute;
>     my @authorised_values= Koha::AuthorisedValueCategories->search->get_column('category_name');
> 
>     # build thesaurus categories list
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 36395: 163679 | 163726 | 164200