Attachment 163772 Details for Bug 36018 – Bug 36018: (follow-up) Do not rely on assumed correct quantities

[patch] Bug 36018: (follow-up) Do not rely on assumed correct quantities

Bug-36018-follow-up-Do-not-rely-on-assumed-correct.patch (text/plain), 2.86 KB, created by Marcel de Rooy on 2024-03-25 09:49:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2024-03-25 09:49:23 UTC

Size: 2.86 KB

patch

obsolete

>From 0f3f0839887af3cfbf76862e451ac2663054d5cd Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Mon, 25 Mar 2024 09:46:06 +0000
>Subject: [PATCH] Bug 36018: (follow-up) Do not rely on assumed correct
> quantities
>Content-Type: text/plain; charset=utf-8
>
>Now filter_by_active checks quantities, we should ascertain that
>our test data is correct, not leaving it to random values from
>TestBuilder.
>
>Test plan:
>Run t/db_dependent/Koha/Acquisition/Order.t
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/Koha/Acquisition/Order.t | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
>diff --git a/t/db_dependent/Koha/Acquisition/Order.t b/t/db_dependent/Koha/Acquisition/Order.t
>index 4679fb7489..92d4d6917b 100755
>--- a/t/db_dependent/Koha/Acquisition/Order.t
>+++ b/t/db_dependent/Koha/Acquisition/Order.t
>@@ -417,6 +417,8 @@ subtest 'filter_by_late' => sub {
>                 datecancellationprinted => undef,
>                 estimated_delivery_date => undef,
>                 orderstatus             => 'ordered',
>+                quantity                => 1,
>+                quantityreceived        => 0,
>             }
>         }
>     );
>@@ -438,6 +440,8 @@ subtest 'filter_by_late' => sub {
>                 datecancellationprinted => undef,
>                 estimated_delivery_date => undef,
>                 orderstatus             => 'ordered',
>+                quantity                => 1,
>+                quantityreceived        => 0,
>             }
>         }
>     );
>@@ -459,6 +463,8 @@ subtest 'filter_by_late' => sub {
>                 datecancellationprinted => undef,
>                 estimated_delivery_date => undef,
>                 orderstatus             => 'ordered',
>+                quantity                => 1,
>+                quantityreceived        => 0,
>             }
>         }
>     );
>@@ -480,6 +486,8 @@ subtest 'filter_by_late' => sub {
>                 datecancellationprinted => undef,
>                 estimated_delivery_date => undef,
>                 orderstatus             => 'ordered',
>+                quantity                => 1,
>+                quantityreceived        => 0,
>             }
>         }
>     );
>@@ -492,6 +500,8 @@ subtest 'filter_by_late' => sub {
>                 datecancellationprinted => undef,
>                 estimated_delivery_date => undef,
>                 orderstatus             => 'complete',
>+                quantity                => 1,
>+                quantityreceived        => 0,
>             }
>         }
>     );
>@@ -576,6 +586,8 @@ subtest 'filter_by_late' => sub {
>                 datereceived            => undef,
>                 datecancellationprinted => undef,
>                 estimated_delivery_date => $now->clone->subtract( days => 2 ),
>+                quantity                => 1,
>+                quantityreceived        => 0,
>             }
>         }
>     );
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 36018: 162318 | 162320 | 162321 | 163769 | 163770 | 163771 | 163772 | 164953 | 164954 | 164955 | 164956 | 165153 | 166503 | 166504 | 166505 | 166506 | 166507 | 166677