Bugzilla – Attachment 163815 Details for
Bug 35581
ILL Koha classes are not consistent
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35581: (follow-up) Remove internal use of ->illrequestattributes
Bug-35581-follow-up-Remove-internal-use-of--illreq.patch (text/plain), 1.64 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-03-25 13:34:16 UTC
(
hide
)
Description:
Bug 35581: (follow-up) Remove internal use of ->illrequestattributes
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-03-25 13:34:16 UTC
Size:
1.64 KB
patch
obsolete
>From 09a0300f7a2d0235918ed505ae3d64d8533b20a0 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 25 Mar 2024 10:08:18 -0300 >Subject: [PATCH] Bug 35581: (follow-up) Remove internal use of > ->illrequestattributes > >By now, we shouldn't be using the deprecated method internally. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/ILL/Request.pm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/Koha/ILL/Request.pm b/Koha/ILL/Request.pm >index 5bf9717a074..f525ef12eff 100644 >--- a/Koha/ILL/Request.pm >+++ b/Koha/ILL/Request.pm >@@ -1160,7 +1160,7 @@ Return a string representing the material type of this request or undef > > sub get_type { > my ($self) = @_; >- my $attr = $self->illrequestattributes->find({ type => 'type'}); >+ my $attr = $self->extended_attributes->find({ type => 'type'}); > return if !$attr; > return $attr->value; > }; >@@ -1766,10 +1766,10 @@ and transport type > sub get_notice { > my ( $self, $params ) = @_; > >- my $title = $self->illrequestattributes->find( >+ my $title = $self->extended_attributes->find( > { type => 'title' } > ); >- my $author = $self->illrequestattributes->find( >+ my $author = $self->extended_attributes->find( > { type => 'author' } > ); > my $metahash = $self->metadata; >@@ -1781,7 +1781,7 @@ sub get_notice { > my $metastring = join("\n", @metaarray); > > my $illrequestattributes = { >- map { $_->type => $_->value } $self->illrequestattributes->as_list >+ map { $_->type => $_->value } $self->extended_attributes->as_list > }; > > my $letter = C4::Letters::GetPreparedLetter( >-- >2.44.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35581
:
159863
|
159864
|
159865
|
159866
|
159867
|
159868
|
159869
|
159870
|
159871
|
159872
|
159873
|
160422
|
160423
|
160424
|
160425
|
160426
|
160427
|
160428
|
160429
|
160430
|
160431
|
160432
|
160620
|
160622
|
162020
|
162021
|
162022
|
162023
|
162024
|
162025
|
162026
|
162027
|
162028
|
162029
|
162030
|
162031
|
162032
|
162817
|
162818
|
162819
|
162820
|
162821
|
162822
|
162823
|
162824
|
162825
|
162826
|
162827
|
162828
|
162829
|
162880
|
162881
|
162882
|
162883
|
162884
|
162885
|
162886
|
162887
|
162888
|
162889
|
162890
|
162891
|
162892
|
163803
|
163804
|
163805
|
163806
|
163807
|
163808
|
163809
|
163810
|
163811
|
163812
|
163813
|
163814
|
163815
|
163816
|
164069
|
164070
|
164071
|
164072
|
164073
|
164074
|
164075
|
164076
|
164077
|
164078
|
164079
|
164080
|
164081
|
164082
|
165448