Attachment 163913 Details for Bug 33478 – Bug 33478: Apply formatting to RECALL_REQUESTER_DET

[patch] Bug 33478: Apply formatting to RECALL_REQUESTER_DET

Bug-33478-Apply-formatting-to-RECALLREQUESTERDET.patch (text/plain), 1.48 KB, created by Nick Clemens (kidclamp) on 2024-03-26 12:29:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-03-26 12:29:17 UTC

Size: 1.48 KB

patch

obsolete

>From f90926056b0982522d63ad461eae8282e4afff6a Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleisha@catalyst.net.nz>
>Date: Sun, 12 Nov 2023 21:37:02 +0000
>Subject: [PATCH] Bug 33478: Apply formatting to RECALL_REQUESTER_DET
>
>To test:
>
>1. Enable UseRecalls system preference and configure all relevant recalls circulation and fines rules
>2. Search for a record with only one item
>3. Check out this item to Patron A
>4. Log into the OPAC as Patron B
>5. Search for the item and place a recall
>6. Go back to the staff interface
>7. Check in the item
>8. When the pop-up for the recall is triggered, confirm recall and print slip
>9. Confirm your format settings for RECALL_REQUESTER_DET are applied
>---
> recalls/recall_pickup_slip.pl | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
>diff --git a/recalls/recall_pickup_slip.pl b/recalls/recall_pickup_slip.pl
>index 20816db517f..19e439ce29f 100755
>--- a/recalls/recall_pickup_slip.pl
>+++ b/recalls/recall_pickup_slip.pl
>@@ -58,16 +58,18 @@ my $letter = C4::Letters::GetPreparedLetter(
>     }
> );
> 
>-my ($slip, $is_html);
>+my ( $slip, $is_html, $style );
> if ($letter) {
>-    $slip = $letter->{content};
>+    $slip    = $letter->{content};
>     $is_html = $letter->{is_html};
>+    $style   = $letter->{style};
> }
> 
> $template->param(
>-    slip => $slip,
>-    plain => !$is_html,
>+    slip   => $slip,
>+    plain  => !$is_html,
>     caller => 'recall',
>+    style  => $style,
> );
> 
> output_html_with_http_headers $input, $cookie, $template->output;
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 33478: 149743 | 149785 | 149786 | 149787 | 149914 | 149915 | 149916 | 149917 | 149918 | 149999 | 150000 | 150001 | 150002 | 150003 | 150004 | 150005 | 150006 | 150007 | 150008 | 150009 | 150010 | 150011 | 150012 | 150265 | 150266 | 150267 | 150268 | 150269 | 150270 | 150271 | 150272 | 150273 | 150274 | 150275 | 150276 | 150277 | 150324 | 150325 | 150326 | 150327 | 150328 | 150329 | 150330 | 150331 | 150332 | 150333 | 150334 | 150335 | 150336 | 150337 | 150338 | 150339 | 150340 | 150341 | 150342 | 150343 | 150344 | 150345 | 151548 | 151580 | 151581 | 151582 | 151583 | 151584 | 151585 | 151586 | 151587 | 151588 | 151589 | 151590 | 151591 | 151592 | 151593 | 156469 | 157368 | 157369 | 157370 | 157371 | 157372 | 157373 | 157374 | 157375 | 157376 | 157377 | 157378 | 157379 | 157380 | 157381 | 157382 | 157387 | 158835 | 158836 | 158837 | 158838 | 158839 | 158840 | 158841 | 158842 | 158843 | 158844 | 158845 | 158846 | 158847 | 158848 | 158849 | 158856 | 162556 | 162557 | 162558 | 162559 | 162560 | 162561 | 162562 | 162563 | 162564 | 162565 | 162566 | 162567 | 162568 | 162569 | 163903 | 163904 | 163905 | 163906 | 163907 | 163908 | 163909 | 163910 | 163911 | 163912 | 163913 | 163914 | 163915 | 163916 | 163924 | 163925 | 163926 | 163927 | 163928 | 163929 | 163930 | 163931 | 163932 | 163933 | 163934 | 163935 | 163936 | 163937 | 163938 | 164719 | 164720 | 164721 | 164722 | 164723 | 164724 | 164725 | 164726 | 164727 | 164728 | 164729 | 164730 | 164731 | 164732 | 164733 | 164741 | 164742 | 164743 | 164744 | 164745 | 164746 | 164747 | 164748 | 164749 | 164750 | 164751 | 164752 | 164753 | 164754 | 164755