Bugzilla – Attachment 164033 Details for
Bug 36443
Add 'fax' to batch patron modification tool
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36443: Add a fax field / column to the batch patron modification tool
Bug-36443-Add-a-fax-field--column-to-the-batch-pat.patch (text/plain), 4.83 KB, created by
Laura Escamilla
on 2024-03-27 19:59:27 UTC
(
hide
)
Description:
Bug 36443: Add a fax field / column to the batch patron modification tool
Filename:
MIME Type:
Creator:
Laura Escamilla
Created:
2024-03-27 19:59:27 UTC
Size:
4.83 KB
patch
obsolete
>From c5886b18ed9359922cb2b285381003003d552723 Mon Sep 17 00:00:00 2001 >From: Laura Escamilla <laura.escamilla@bywatersolutions.com> >Date: Wed, 27 Mar 2024 19:55:26 +0000 >Subject: [PATCH] Bug 36443: Add a fax field / column to the batch patron > modification tool >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >To test: >1. Create or modify an existing patron account so that they have a value in their fax number field. >2. Go to Tools > Batch patron modification > 1. Add the patron card number, or borrower number into the modification tool and click on continue. There is no option for modifying fax numbers, nor are fax numbers visible in the modification table. >3. Apply the patch and restart_all >4. Repeat step 2 > 1. A column for âFaxâ is now visible after âOther phoneâ > 2. Test the âFaxâ field by clearing out the field with the checkbox. âChecking the box right next to the label will disable the entry and delete the values of that field on all selected patrons.â > 3. Test the âFaxâ field by updating the value with a new number >5. Sign off and have a wonderful day :) >--- > .../intranet-tmpl/prog/en/modules/tools/modborrowers.tt | 3 +++ > tools/modborrowers.pl | 8 +++++++- > 2 files changed, 10 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >index 9dac594e99..566b9e59ad 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt >@@ -254,6 +254,7 @@ > <th>Primary email</th> > <th>Primary phone</th> > <th>Other phone</th> >+ <th>Fax</th> > <th>Registration date</th> > <th>Expiry date</th> > [% IF CanUpdatePasswordExpiration %] >@@ -293,6 +294,7 @@ > <td>[% borrower.email | html %]</td> > <td>[% borrower.phone | html %]</td> > <td>[% borrower.mobile | html %]</td> >+ <td>[% borrower.fax | html %]</td> > <td data-order="[% borrower.dateenrolled | html %]">[% borrower.dateenrolled | $KohaDates %]</td> > <td data-order="[% borrower.dateexpiry | html %]">[% borrower.dateexpiry | $KohaDates %]</td> > [% IF CanUpdatePasswordExpiration %] >@@ -351,6 +353,7 @@ > [% CASE 'email' %]<span>Primary email:</span> > [% CASE 'phone' %]<span>Primary phone:</span> > [% CASE 'mobile' %]<span>Other phone:</span> >+ [% CASE 'fax' %]<span>Fax:</span> > [% CASE 'sort1' %]<span>Sort 1:</span> > [% CASE 'sort2' %]<span>Sort 2:</span> > [% CASE 'dateenrolled' %]<span>Registration date:</span> >diff --git a/tools/modborrowers.pl b/tools/modborrowers.pl >index 2a6e7c07d8..bc12c259e5 100755 >--- a/tools/modborrowers.pl >+++ b/tools/modborrowers.pl >@@ -279,6 +279,12 @@ if ( $op eq 'cud-show' ) { > type => "text", > mandatory => ( grep /mobile/, @mandatoryFields ) ? 1 : 0, > } >+ , >+ { >+ name => "fax", >+ type => "text", >+ mandatory => ( grep /fax/, @mandatoryFields ) ? 1 : 0, >+ } > , > { > name => "sort1", >@@ -345,7 +351,7 @@ if ( $op eq 'cud-do' ) { > > my @disabled = $input->multi_param('disable_input'); > my $infos; >- for my $field ( qw/surname firstname branchcode categorycode streetnumber address address2 city state zipcode country email phone mobile sort1 sort2 dateenrolled dateexpiry password_expiration_date borrowernotes opacnote debarred debarredcomment/ ) { >+ for my $field ( qw/surname firstname branchcode categorycode streetnumber address address2 city state zipcode country email phone mobile fax sort1 sort2 dateenrolled dateexpiry password_expiration_date borrowernotes opacnote debarred debarredcomment/ ) { > my $value = $input->param($field); > $infos->{$field} = $value if $value; > $infos->{$field} = "" if grep { $_ eq $field } @disabled; >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36443
:
164033
|
164092
|
164225