Bugzilla – Attachment 164102 Details for
Bug 36418
Set response's content-type to application/json when needed - svc scripts
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36418: Explicitly set response to json
Bug-36418-Explicitly-set-response-to-json.patch (text/plain), 2.00 KB, created by
Jonathan Druart
on 2024-03-29 07:28:30 UTC
(
hide
)
Description:
Bug 36418: Explicitly set response to json
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-03-29 07:28:30 UTC
Size:
2.00 KB
patch
obsolete
>From 41951d8d70d9c4c82b58c2e1ea6e803fb19997a5 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Mon, 25 Mar 2024 16:30:51 +0000 >Subject: [PATCH] Bug 36418: Explicitly set response to json > >To test: >1. Add some checkouts and load the issues-table >2. Select 'Check in' checkbox for that item and click "Check in selected items" >3. The row becomes read and reads "Unable to check in" >4. Reload the page, the item has actually checked in > >5. Try the 'Renew' checkbox and click "Renew selected items" >6. It just spins and spins. >7. Reload the page, the item has actually renewed. >8. APPLY PATCH and restart_all >9. Try the steps again and this time everything should work properly. >10. tests these URLs >http://localhost:8081/cgi-bin/koha/svc/recall >http://localhost:8080/cgi-bin/koha/svc/club/enroll >http://localhost:8081/cgi-bin/koha/svc/mana/increment : empty response > >Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > svc/checkin | 2 +- > svc/renew | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/svc/checkin b/svc/checkin >index 9ba087bd4db..48fa7185432 100755 >--- a/svc/checkin >+++ b/svc/checkin >@@ -41,7 +41,7 @@ if ( $auth_status ne "ok" || $op ne "cud-checkin" ) { > } > > binmode STDOUT, ":encoding(UTF-8)"; >-print $input->header( -type => 'text/plain', -charset => 'UTF-8' ); >+print $input->header( -type => 'application/json', -charset => 'UTF-8' ); > > my $itemnumber = $input->param('itemnumber'); > my $borrowernumber = $input->param('borrowernumber'); >diff --git a/svc/renew b/svc/renew >index eca18e647f8..67a658b0703 100755 >--- a/svc/renew >+++ b/svc/renew >@@ -40,7 +40,7 @@ if ( $auth_status ne "ok" ) { > } > > binmode STDOUT, ":encoding(UTF-8)"; >-print $input->header( -type => 'text/plain', -charset => 'UTF-8' ); >+print $input->header( -type => 'application/json', -charset => 'UTF-8' ); > > my $itemnumber = $input->param('itemnumber'); > my $borrowernumber = $input->param('borrowernumber'); >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36418
:
163837
|
163885
|
163922
|
163923
|
164066
|
164094
|
164095
|
164096
|
164097
| 164102 |
164103
|
164104
|
164105