Bugzilla – Attachment 164112 Details for
Bug 36368
Cannot save new patron after error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36368: (QA follow-up) Remove unneeded line
Bug-36368-QA-follow-up-Remove-unneeded-line.patch (text/plain), 1.15 KB, created by
Marcel de Rooy
on 2024-03-29 08:27:05 UTC
(
hide
)
Description:
Bug 36368: (QA follow-up) Remove unneeded line
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2024-03-29 08:27:05 UTC
Size:
1.15 KB
patch
obsolete
>From 2ccdedef64fc733f3ebe740c73079783f1c8a052 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 29 Mar 2024 08:23:57 +0000 >Subject: [PATCH] Bug 36368: (QA follow-up) Remove unneeded line >Content-Type: text/plain; charset=utf-8 > >As Emmy stated on comment9, this line is indeed unneeded (and wrong). >A successful cud-insert/cud-save does not come here. >And it is set for add_form, edit_form and duplicate later on. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > members/memberentry.pl | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index c2e6edfdbe..702f2c6898 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -601,7 +601,6 @@ if ($nok or !$nodouble){ > $op = 'add_form' if ( $op eq 'cud-insert' ); > $op = 'edit_form' if ( $op eq 'cud-save' ); > %data=%newdata; >- $template->param( updtype => ($op eq 'add' ?'I':'M')); # used to check for $op eq "cud-insert"... but we just changed $op! > unless ($step){ > $template->param( step_1 => 1,step_2 => 1,step_3 => 1, step_4 => 1, step_5 => 1, step_6 => 1, step_7 => 1 ); > } >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36368
:
163526
|
163624
|
163625
|
164111
| 164112