Bugzilla – Attachment 164123 Details for
Bug 36382
XSS in showLastPatron dropdown
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 36382 (QA follow-up) Don't escape quotes in escapeHtml
Bug-36382-QA-follow-up-Dont-escape-quotes-in-escap.patch (text/plain), 893 bytes, created by
Kyle M Hall (khall)
on 2024-03-29 11:08:05 UTC
(
hide
)
Description:
Bug 36382 (QA follow-up) Don't escape quotes in escapeHtml
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2024-03-29 11:08:05 UTC
Size:
893 bytes
patch
obsolete
>From 9d3c30719c49c070d886c3b554806d52aa3166f1 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Fri, 29 Mar 2024 07:07:54 -0400 >Subject: [PATCH] Bug 36382 (QA follow-up) Don't escape quotes in escapeHtml > >--- > koha-tmpl/intranet-tmpl/prog/js/staff-global.js | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js >index 636522fa44e..92ad13f0b46 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js >@@ -19,9 +19,7 @@ function formatstr(str, col) { > var HtmlCharsToEscape = { > '&': '&', > '<': '<', >- '>': '>', >- "'": ''', >- '"': '"' >+ '>': '>' > }; > String.prototype.escapeHtml = function() { > return this.replace(/[&<>]/g, function(c) { >-- >2.30.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 36382
:
163615
|
163727
|
164119
|
164123
|
166717
|
166718