Attachment 164232 Details for Bug 36469 – Bug 36469: Fix conflict between _header.scss and addbiblio.css tab style

[patch] Bug 36469: Fix conflict between _header.scss and addbiblio.css tab style

Bug-36469-Fix-conflict-between-headerscss-and-addb.patch (text/plain), 1.49 KB, created by David Nind on 2024-04-02 05:29:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-04-02 05:29:24 UTC

Size: 1.49 KB

patch

obsolete

>From 118bd3ab6bd4dc1b9dd30c59368cbafcb9688b75 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 1 Apr 2024 12:22:15 +0000
>Subject: [PATCH] Bug 36469: Fix conflict between _header.scss and
> addbiblio.css tab style
>
>addbiblio.css adds padding to tab panes specific for that interface, and
>the header search form should not pick up that style. This patch adds
>some specificity to _header.scss to avoid unwanted padding.
>
>To test, apply the patch and rebuild the staff interface CSS
>(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface).
>
>- Go to Cataloging -> New record (using the basic MARC editor).
>  - The style of the MARC edit form should look correct.
>  - The header search form should look correct
>- Test other pages with tabs to confirm that there are no other unwanted
>  side-effects, e.g. Circulation -> Check out; Advanced catalog search;
>  Bibliographic detail page.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/css/src/_header.scss | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_header.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_header.scss
>index e1bbb99a33..d9ea5bde05 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/_header.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/_header.scss
>@@ -244,6 +244,10 @@ a.navbar-toggle {
> 
>     &.toptabs {
>         margin-top: 0;
>+
>+        .tab-pane {
>+            padding: 0;
>+        }
>     }
> 
>     .nav-tabs {
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 36469: 164178 | 164232 | 164253