Attachment 164286 Details for Bug 36494 – Bug 36494: Flatpickr error on checkout page if the patron is blocked from checking out

[patch] Bug 36494: Flatpickr error on checkout page if the patron is blocked from checking out

Bug-36494-Flatpickr-error-on-checkout-page-if-the-.patch (text/plain), 2.14 KB, created by Owen Leonard on 2024-04-02 17:17:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2024-04-02 17:17:28 UTC

Size: 2.14 KB

patch

obsolete

>From 065370c5a1abf4edb7644115e827f1e6cc69656f Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Tue, 2 Apr 2024 17:03:21 +0000
>Subject: [PATCH] Bug 36494: Flatpickr error on checkout page if the patron is
> blocked from checking out
>
>This patch add some error-handling to the recent change to
>circulation.tt where we handle dates and on-site checkouts. This
>prevents an error in the console when the patron is blocked and the
>"specify due date" field is hidden.
>
>To test, apply the patch and make sure OnSiteCheckouts is enabled.
>
>- Go to Circulation and check out to a patron.
>- Under the restrictions tab, add a manual restriction.
>- When the page reloads and the checkout form is no longer visible,
>  confirm that there is no error in the browser console.
>
>Confirm that the Bug 18885 test plan still works.
>---
> .../prog/en/modules/circ/circulation.tt             | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>index d4aa69dc30..d7f07d69ca 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
>@@ -1040,11 +1040,14 @@
> 
>         // On-site checkout
>         function toggle_onsite_checkout(){
>-            const duedatespec_fp = document.querySelector("#duedatespec")._flatpickr;
>-            if ( $("#onsite_checkout").prop('checked') ) {
>-                duedatespec_fp.setDate("[% today_due_date_and_time | $KohaDates dateformat => 'iso', with_hours => 1 %]");
>-            } else {
>-                duedatespec_fp.setDate("");
>+            const duedatespec = document.querySelector("#duedatespec");
>+            if( duedatespec ){
>+                const duedatespec_fp = duedatespec._flatpickr;
>+                if ( $("#onsite_checkout").prop('checked') ) {
>+                    duedatespec_fp.setDate("[% today_due_date_and_time | $KohaDates dateformat => 'iso', with_hours => 1 %]");
>+                } else {
>+                    duedatespec_fp.setDate("");
>+                }
>             }
>         }
> 
>-- 
>2.30.2

Actions: View | Diff | Splinter Review

Attachments on bug 36494: 164286 | 164440 | 164734