Attachment 164310 Details for Bug 33568 – Bug 33568: Display string version of coded values + format dates

[patch] Bug 33568: Display string version of coded values + format dates

Bug-33568-Display-string-version-of-coded-values--.patch (text/plain), 3.71 KB, created by Jonathan Druart on 2024-04-03 07:37:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-04-03 07:37:29 UTC

Size: 3.71 KB

patch

obsolete

>From fd085b91ecca8bc1a44436bd9d1b1d125587626d Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 13 Apr 2023 13:03:46 +0200
>Subject: [PATCH] Bug 33568: Display string version of coded values + format
> dates
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Laurence Rault <laurence.rault@biblibre.com>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>Signed-off-by: TomÃ¡s Cohen Arazi <tomascohen@theke.io>
>---
> .../prog/en/modules/catalogue/detail.tt           | 15 ++++++++-------
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index af97ac28643..0f2ed85b7b5 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -2495,6 +2495,7 @@
>         var items_table = $("#table_items").kohaTable({
>             ajax: { url: table_url },
>             order: [[ 0, "asc" ]],
>+            embed: ["+strings"],
>             bAutoWidth: false,
>             columns: [
>             [% IF (StaffDetailItemSelection) %]
>@@ -2524,7 +2525,7 @@
>                 searchable: true,
>                 orderable: true,
>                 render: function (data, type, row, meta) {
>-                    return row.effective_item_type_id; // FIXME Display the translated description and the image
>+                    return row._strings.item_type_id.str; // FIXME Display the image
>                 }
>             },
>             [% END %]
>@@ -2533,7 +2534,7 @@
>                 searchable: true,
>                 orderable: true,
>                 render: function (data, type, row, meta) {
>-                    return row.holding_library_id; // FIXME Display library name
>+                    return row._strings.holding_library_id.str;
>                 }
>             },
>             {
>@@ -2541,7 +2542,7 @@
>                 searchable: true,
>                 orderable: true,
>                 render: function (data, type, row, meta) {
>-                    return row.home_library_id; // FIXME Display library name
>+                    return row._strings.home_library_id.str;
>                 }
>                 // FIXME Display the shelving location
>             },
>@@ -2551,7 +2552,7 @@
>                 searchable: true,
>                 orderable: true,
>                 render: function (data, type, row, meta) {
>-                    return row.collection_code; // FIXME Display str version
>+                    return row._strings.collection_code.str;
>                 }
>             },
>             [% END %]
>@@ -2597,7 +2598,7 @@
>                 searchable: true,
>                 orderable: true,
>                 render: function (data, type, row, meta) {
>-                    return row.last_seen_date; // FIXME Format date
>+                    return $date(row.last_seen_date);
>                 }
>             },
>             {
>@@ -2621,7 +2622,7 @@
>                 searchable: true,
>                 orderable: true,
>                 render: function (data, type, row, meta) {
>-                    return row.acquisition_date; // FIXME Format date
>+                    return $date(row.acquisition_date);
>                 }
>             },
>             {
>@@ -2629,7 +2630,7 @@
>                 searchable: true,
>                 orderable: true,
>                 render: function (data, type, row, meta) {
>-                    return row.last_checkout_date; // FIXME Format date
>+                    return $date(row.last_checkout_date);
>                 }
>             },
>             {
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 33568: 151339 | 153791 | 164308 | 164309 | 164310 | 164311 | 164312 | 164313 | 164314 | 164315 | 164316 | 164317 | 164318 | 164319 | 164320 | 164321 | 164322 | 164323 | 164324 | 164325 | 164326 | 164327 | 164328 | 164329 | 164330 | 164331 | 164332 | 164333 | 164334 | 164335 | 164336 | 164337 | 164338 | 164339 | 164340 | 164341 | 164342 | 164343 | 164344 | 164345 | 164346 | 164347 | 164348 | 164349 | 164350 | 164351 | 164352 | 164353 | 164354 | 164355 | 164356 | 164358 | 164359 | 164360 | 164361 | 164362 | 164363 | 164364 | 164365 | 164366 | 164367 | 164368 | 164369 | 164370 | 164371 | 164372 | 164373 | 164374 | 164472 | 164480 | 164482 | 164483 | 164485 | 164528