Attachment 164317 Details for Bug 33568 – Bug 33568: fix DataTables bKohaColumnsUseNames

[patch] Bug 33568: fix DataTables bKohaColumnsUseNames

Bug-33568-fix-DataTables-bKohaColumnsUseNames.patch (text/plain), 2.25 KB, created by Jonathan Druart on 2024-04-03 07:38:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-04-03 07:38:00 UTC

Size: 2.25 KB

patch

obsolete

>From 1103d984c21ab91853a53d01438518e424f54572 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 13 Apr 2023 16:09:59 +0200
>Subject: [PATCH] Bug 33568: fix DataTables bKohaColumnsUseNames
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Looks like this bug does not exist in Koha, but we hit it here.
>Could be moved to its own bug.
>Compare with ../includes/columns_settings.inc (code that is used prior
>to this change)
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Laurence Rault <laurence.rault@biblibre.com>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>Signed-off-by: TomÃ¡s Cohen Arazi <tomascohen@theke.io>
>---
> koha-tmpl/intranet-tmpl/prog/js/datatables.js | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/datatables.js b/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>index e03c0c2a3e2..323b21d7e17 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/datatables.js
>@@ -780,14 +780,15 @@ function _dt_buttons(params){
>     return buttons;
> }
> 
>-function _dt_visibility(table_settings, settings){
>+function _dt_visibility(node, table_settings, settings){
>     var counter = 0;
>     let hidden_ids = [];
>     let included_ids = [];
>     if ( table_settings ) {
>         var columns_settings = table_settings['columns'];
>         $(columns_settings).each( function() {
>-            var named_id = $( 'thead th[data-colname="' + this.columnname + '"]', this ).index( 'th' );
>+            let selector = '#' + node.attr('id');
>+            var named_id = $( 'thead th[data-colname="' + this.columnname + '"]', selector ).index( selector + ' th' );
>             var used_id = settings.bKohaColumnsUseNames ? named_id : counter;
>             if ( used_id == -1 ) return;
> 
>@@ -974,7 +975,7 @@ function _dt_add_delay(table_dt, table_node, delay_ms) {
>         }
> 
>         let hidden_ids, included_ids;
>-        [hidden_ids, included_ids] = _dt_visibility(table_settings, settings)
>+        [hidden_ids, included_ids] = _dt_visibility(this, table_settings, settings)
> 
>         settings["buttons"] = _dt_buttons({included_ids, settings, table_settings});
> 
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 33568: 151339 | 153791 | 164308 | 164309 | 164310 | 164311 | 164312 | 164313 | 164314 | 164315 | 164316 | 164317 | 164318 | 164319 | 164320 | 164321 | 164322 | 164323 | 164324 | 164325 | 164326 | 164327 | 164328 | 164329 | 164330 | 164331 | 164332 | 164333 | 164334 | 164335 | 164336 | 164337 | 164338 | 164339 | 164340 | 164341 | 164342 | 164343 | 164344 | 164345 | 164346 | 164347 | 164348 | 164349 | 164350 | 164351 | 164352 | 164353 | 164354 | 164355 | 164356 | 164358 | 164359 | 164360 | 164361 | 164362 | 164363 | 164364 | 164365 | 164366 | 164367 | 164368 | 164369 | 164370 | 164371 | 164372 | 164373 | 164374 | 164472 | 164480 | 164482 | 164483 | 164485 | 164528