Bugzilla – Attachment 164341 Details for
Bug 33568
Use the REST API to display items on the staff biblio detail view
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 33568: Bug 33568: Display library names instead of codes for recall
Bug-33568-Bug-33568-Display-library-names-instead-.patch (text/plain), 3.28 KB, created by
Jonathan Druart
on 2024-04-03 07:39:49 UTC
(
hide
)
Description:
Bug 33568: Bug 33568: Display library names instead of codes for recall
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-04-03 07:39:49 UTC
Size:
3.28 KB
patch
obsolete
>From 9fdb5b8193c82c93d05bbcd02c68eb5747566eae Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 23 May 2023 13:37:33 +0200 >Subject: [PATCH] Bug 33568: Bug 33568: Display library names instead of codes > for recall >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Laurence Rault <laurence.rault@biblibre.com> >Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> >Signed-off-by: Tomás Cohen Arazi <tomascohen@theke.io> >--- > Koha/Recall.pm | 15 +++++++++++++++ > api/v1/swagger/paths/biblios.yaml | 1 + > .../prog/en/modules/catalogue/detail.tt | 4 ++-- > 3 files changed, 18 insertions(+), 2 deletions(-) > >diff --git a/Koha/Recall.pm b/Koha/Recall.pm >index c70acb89dd1..6f3678f691f 100644 >--- a/Koha/Recall.pm >+++ b/Koha/Recall.pm >@@ -461,6 +461,21 @@ sub set_fulfilled { > return $self; > } > >+=head3 strings_map >+ >+Returns a map of column name to string representations including the string. >+ >+=cut >+ >+sub strings_map { >+ my ($self) = @_; >+ return { >+ pickup_library_id => { str => $self->library->branchname, type => 'library' }, >+ }; >+} >+ >+ >+ > =head2 Internal methods > > =head3 _type >diff --git a/api/v1/swagger/paths/biblios.yaml b/api/v1/swagger/paths/biblios.yaml >index 6256d9d9494..95d5062f57d 100644 >--- a/api/v1/swagger/paths/biblios.yaml >+++ b/api/v1/swagger/paths/biblios.yaml >@@ -431,6 +431,7 @@ > - first_hold+strings > - first_hold.patron > - recall >+ - recall+strings > - recall.patron > - item_type > - in_bundle >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index 62cf24ea27c..91511709653 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -2184,7 +2184,7 @@ > embed.push('serialitem.serial'); > [% END %] > [% IF Koha.Preference('UseRecalls') %] >- embed.push('recall', 'recall.patron') >+ embed.push('recall', 'recall+strings', 'recall.patron') > [% END %] > embed.push('in_bundle', 'bundle_host'); > [% IF Koha.Preference('UseCourseReserves') %] >@@ -2441,7 +2441,7 @@ > [% IF Koha.Preference('UseRecalls') %] > if ( row.recall ) { > if ( row.recall.waiting_date ) { >- nodes += '<span>%s</span>'.format(_("Waiting at %s since %s").format(escape_str(row.recall.pickup_library_id), $date(row.recall.waiting_date))); # FIXME Display library names instead of codes >+ nodes += '<span>%s</span>'.format(_("Waiting at %s since %s").format(escape_str(row.recall.pickup_library_id.str), $date(row.recall.waiting_date))); > } else { > let patron_to_html = $patron_to_html(row.recall.patron); > nodes += '<span>%s</span>'.format(_("recalled by %s on %s").format(patron_to_html, $date(row.recall.created_date))) >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 33568
:
151339
|
153791
|
164308
|
164309
|
164310
|
164311
|
164312
|
164313
|
164314
|
164315
|
164316
|
164317
|
164318
|
164319
|
164320
|
164321
|
164322
|
164323
|
164324
|
164325
|
164326
|
164327
|
164328
|
164329
|
164330
|
164331
|
164332
|
164333
|
164334
|
164335
|
164336
|
164337
|
164338
|
164339
|
164340
|
164341
|
164342
|
164343
|
164344
|
164345
|
164346
|
164347
|
164348
|
164349
|
164350
|
164351
|
164352
|
164353
|
164354
|
164355
|
164356
|
164358
|
164359
|
164360
|
164361
|
164362
|
164363
|
164364
|
164365
|
164366
|
164367
|
164368
|
164369
|
164370
|
164371
|
164372
|
164373
|
164374
|
164472
|
164480
|
164482
|
164483
|
164485
|
164528