Attachment 164348 Details for Bug 33568 – Bug 33568: Fix select/clear all links

[patch] Bug 33568: Fix select/clear all links

Bug-33568-Fix-selectclear-all-links.patch (text/plain), 3.25 KB, created by Jonathan Druart on 2024-04-03 07:40:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-04-03 07:40:22 UTC

Size: 3.25 KB

patch

obsolete

>From db21e56eb1c65d0c3c6cd1061acfcc313148f304 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 30 May 2023 10:28:00 +0200
>Subject: [PATCH] Bug 33568: Fix select/clear all links
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>Follow-up for "Bug 33568: Preserve item selection across pagination and filtering"
>
>FIXME We should deal with the items selection in a better way, but I
>would not consider it blocker, that can be done later.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Laurence Rault <laurence.rault@biblibre.com>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>Signed-off-by: TomÃ¡s Cohen Arazi <tomascohen@theke.io>
>---
> .../tables/items/catalogue_detail.inc         | 24 ++++++++++++-------
> 1 file changed, 15 insertions(+), 9 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>index fe410833bb1..5b389c90f62 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>@@ -105,11 +105,11 @@
>         function itemSelectionBuildActionLinks(tab_id) {
>             var delete_link_ok = itemSelectionBuildDeleteLink(tab_id);
>             var modify_link_ok = itemSelectionBuildModifyLink(tab_id);
>-            var div = $("#" + tab_id);
>+            var tab = $("#" + tab_id);
>             if (modify_link_ok || delete_link_ok) {
>-                $('.itemselection_actions', div).show();
>+                $('.itemselection_actions', tab).show();
>             } else {
>-                $('.itemselection_actions', div).hide();
>+                $('.itemselection_actions', tab).hide();
>             }
>         }
> 
>@@ -117,16 +117,22 @@
> 
>             $(".SelectAll").on("click",function(e){
>                 e.preventDefault();
>-                var tab = $(this).data("tab");
>-                $("input[name='itemnumber'][type='checkbox']", $("#"+tab)).prop('checked', true);
>-                itemSelectionBuildActionLinks(tab);
>+                let tab_id = $(this).data("tab");
>+                let tab = $("#"+tab_id);
>+                tab.find("input[name='itemnumber'][type='checkbox']").each( (i, input) => {
>+                    items_selection[tab_id].push($(input).val());
>+                    $(input).prop('checked', true);
>+                });
>+                itemSelectionBuildActionLinks(tab_id);
>             });
> 
>             $(".ClearAll").on("click",function(e){
>                 e.preventDefault();
>-                var tab = $(this).data("tab");
>-                $("input[name='itemnumber'][type='checkbox']", $("#"+tab)).prop('checked', false);
>-                itemSelectionBuildActionLinks(tab);
>+                let tab_id = $(this).data("tab");
>+                let tab = $("#"+tab_id);
>+                items_selection[tab_id] = [];
>+                $("input[name='itemnumber'][type='checkbox']", tab).prop('checked', false);
>+                itemSelectionBuildActionLinks(tab_id);
>             });
> 
>             $(".show_filters").on("click",function(e){
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 33568: 151339 | 153791 | 164308 | 164309 | 164310 | 164311 | 164312 | 164313 | 164314 | 164315 | 164316 | 164317 | 164318 | 164319 | 164320 | 164321 | 164322 | 164323 | 164324 | 164325 | 164326 | 164327 | 164328 | 164329 | 164330 | 164331 | 164332 | 164333 | 164334 | 164335 | 164336 | 164337 | 164338 | 164339 | 164340 | 164341 | 164342 | 164343 | 164344 | 164345 | 164346 | 164347 | 164348 | 164349 | 164350 | 164351 | 164352 | 164353 | 164354 | 164355 | 164356 | 164358 | 164359 | 164360 | 164361 | 164362 | 164363 | 164364 | 164365 | 164366 | 164367 | 164368 | 164369 | 164370 | 164371 | 164372 | 164373 | 164374 | 164472 | 164480 | 164482 | 164483 | 164485 | 164528