Attachment 164353 Details for Bug 33568 – Bug 33568: Fix 'actions' links when filters are shown/hidden

[patch] Bug 33568: Fix 'actions' links when filters are shown/hidden

Bug-33568-Fix-actions-links-when-filters-are-shown.patch (text/plain), 2.49 KB, created by Jonathan Druart on 2024-04-03 07:40:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-04-03 07:40:45 UTC

Size: 2.49 KB

patch

obsolete

>From 22563eff19cebaa9581b87622c5c5c3dbf958601 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 20 Jul 2023 09:16:29 +0200
>Subject: [PATCH] Bug 33568: Fix 'actions' links when filters are shown/hidden
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>It also fixes a problem when "Select all" was clicked, the checkbox
>selection was not kept when the table was refreshed (was comparing
>string and integer, parseInt needed)
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Laurence Rault <laurence.rault@biblibre.com>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>Signed-off-by: TomÃ¡s Cohen Arazi <tomascohen@theke.io>
>---
> .../includes/html_helpers/tables/items/catalogue_detail.inc  | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>index 5e9daedd7b6..f03eb3a7763 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>@@ -123,7 +123,8 @@
>                 let tab_id = $(this).data("tab");
>                 let tab = $("#"+tab_id);
>                 tab.find("input[name='itemnumber'][type='checkbox']").each( (i, input) => {
>-                    items_selection[tab_id].push($(input).val());
>+                    let itemnumber = parseInt($(input).val());
>+                    items_selection[tab_id].push(itemnumber);
>                     $(input).prop('checked', true);
>                 });
>                 itemSelectionBuildActionLinks(tab_id);
>@@ -146,6 +147,7 @@
>                 tab.find(".hide_filters").show();
>                 $("#"+tab_id+"_table thead tr:eq(1)").remove();
>                 build_items_table(tab_id, true, { destroy: true }, build_items_table_drawncallback );
>+                itemSelectionBuildActionLinks(tab_id);
>             });
> 
>             $(".hide_filters").on("click",function(e){
>@@ -156,6 +158,7 @@
>                 tab.find(".show_filters").show();
>                 $("#"+tab_id+"_table thead tr:eq(1)").remove();
>                 build_items_table(tab_id, false, { destroy: true }, build_items_table_drawncallback );
>+                itemSelectionBuildActionLinks(tab_id);
>             });
>         });
>     [% END %]
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 33568: 151339 | 153791 | 164308 | 164309 | 164310 | 164311 | 164312 | 164313 | 164314 | 164315 | 164316 | 164317 | 164318 | 164319 | 164320 | 164321 | 164322 | 164323 | 164324 | 164325 | 164326 | 164327 | 164328 | 164329 | 164330 | 164331 | 164332 | 164333 | 164334 | 164335 | 164336 | 164337 | 164338 | 164339 | 164340 | 164341 | 164342 | 164343 | 164344 | 164345 | 164346 | 164347 | 164348 | 164349 | 164350 | 164351 | 164352 | 164353 | 164354 | 164355 | 164356 | 164358 | 164359 | 164360 | 164361 | 164362 | 164363 | 164364 | 164365 | 164366 | 164367 | 164368 | 164369 | 164370 | 164371 | 164372 | 164373 | 164374 | 164472 | 164480 | 164482 | 164483 | 164485 | 164528