Attachment 164360 Details for Bug 33568 – Bug 33568: Hide holdings tabs if empty (SeparateHoldings)

[patch] Bug 33568: Hide holdings tabs if empty (SeparateHoldings)

Bug-33568-Hide-holdings-tabs-if-empty-SeparateHold.patch (text/plain), 3.21 KB, created by Jonathan Druart on 2024-04-03 07:41:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-04-03 07:41:12 UTC

Size: 3.21 KB

patch

obsolete

>From 521d34518d0c616fef8b8bd218c1a8fa36198106 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 16 Oct 2023 21:03:55 +0200
>Subject: [PATCH] Bug 33568: Hide holdings tabs if empty (SeparateHoldings)
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>See comment 34.
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Laurence Rault <laurence.rault@biblibre.com>
>Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
>Signed-off-by: TomÃ¡s Cohen Arazi <tomascohen@theke.io>
>---
> .../prog/en/modules/catalogue/detail.tt       | 24 ++++++++++++-------
> 1 file changed, 16 insertions(+), 8 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index 8055d18ca7a..5d0db32902b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -273,13 +273,17 @@
> 
> <ul class="nav nav-tabs" role="tablist">
>     [% IF Koha.Preference('SeparateHoldings') %]
>-        <li role="presentation">
>-            [%# FIXME We could build the numbers from DataTable's info %]
>-            <a href="#holdings" aria-controls="holdings" role="tab" data-toggle="tab">[% Branches.GetLoggedInBranchname | html %] holdings ([% items_to_display_count - ( other_holdings_count || 0 ) - ( hidden_count || 0 ) || 0 | html %])</a>
>-        </li>
>-        <li role="presentation">
>-            <a href="#otherholdings"  aria-controls="otherholdings" role="tab" data-toggle="tab">Other holdings ([% other_holdings_count || 0 | html %])</a>
>-        </li>
>+        [% IF items_to_display_count - ( other_holdings_count || 0 ) %]
>+            <li role="presentation">
>+                [%# FIXME We could build the numbers from DataTable's info %]
>+                <a href="#holdings" aria-controls="holdings" role="tab" data-toggle="tab">[% Branches.GetLoggedInBranchname | html %] holdings ([% items_to_display_count - ( other_holdings_count || 0 ) - ( hidden_count || 0 ) || 0 | html %])</a>
>+            </li>
>+        [% END %]
>+        [% IF other_holdings_count %]
>+            <li role="presentation">
>+                <a href="#otherholdings"  aria-controls="otherholdings" role="tab" data-toggle="tab">Other holdings ([% other_holdings_count || 0 | html %])</a>
>+            </li>
>+        [% END %]
>     [% ELSE %]
>         <li role="presentation">
>             <a href="#holdings" aria-controls="holdings" role="tab" data-toggle="tab">Holdings ([% items_to_display_count || 0 | html %])</a>
>@@ -1285,7 +1289,11 @@
>                     $(".nav-tabs a[href='#holdings']").tab("show");
>                 [% END %]
>             [% ELSE %]
>-                $(".nav-tabs a[href='#holdings']").tab("show");
>+                [% IF items_to_display_count - ( other_holdings_count || 0 ) %]
>+                    $(".nav-tabs a[href='#holdings']").tab("show");
>+                [% ELSE %]
>+                    $(".nav-tabs a[href='#otherholdings']").tab("show");
>+                [% END %]
>             [% END %]
>             $('#search-form').focus();
>             $('.thumbnails > li > .remove').click(function() {
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 33568: 151339 | 153791 | 164308 | 164309 | 164310 | 164311 | 164312 | 164313 | 164314 | 164315 | 164316 | 164317 | 164318 | 164319 | 164320 | 164321 | 164322 | 164323 | 164324 | 164325 | 164326 | 164327 | 164328 | 164329 | 164330 | 164331 | 164332 | 164333 | 164334 | 164335 | 164336 | 164337 | 164338 | 164339 | 164340 | 164341 | 164342 | 164343 | 164344 | 164345 | 164346 | 164347 | 164348 | 164349 | 164350 | 164351 | 164352 | 164353 | 164354 | 164355 | 164356 | 164358 | 164359 | 164360 | 164361 | 164362 | 164363 | 164364 | 164365 | 164366 | 164367 | 164368 | 164369 | 164370 | 164371 | 164372 | 164373 | 164374 | 164472 | 164480 | 164482 | 164483 | 164485 | 164528